From patchwork Tue Nov 3 07:47:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5571 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:4121:b0:118:2077:975e with SMTP id d33csp316097laa; Mon, 2 Nov 2026 23:47:59 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvBx0dbjorH6OSEp72MRSG7a/28S6Nz3TEmswaumR3Iu/fwFHZiqOxtzgY19ogkUjcWpUJuITZ4iwwEg=@openvpn.net X-Received: by 2002:a05:701b:424b:20b0:199:7dff:f9cc with SMTP id a92af1059eb24-1ac5ceefcafmr19209509c88.42.1793692079336; Mon, 02 Nov 2026 23:47:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793692079; cv=none; d=google.com; s=arc-20260327; b=W71LlAWtdlkyrmwx4KH7z4LckpPzamM7At7WGqX2l5Ex3Y78vRCMMBkbZuXCIGgoKr qyURXUGWZpw2QH//JFoW/khqg+7rfTKA77F23laJeBeFH+e4GrPzrg8eTbW9FkqFJTz9 BuXnSmDfRSj7NMyHfqIDSHVM/XZY5oIOyM5HhyCj1ur9Wvx2mShpnz0ESYGUdsJquHdj mK5YjWx7XryfL+yP76sbMGhlzYs076ZUDJE3gznybqaV76RaoVOWBmoVaHbZaZMjnxMD 7AvY3ZkBcjzVCjdy38LObp+M0Wq6Y/TnRZHjavmjP1VrTpdVlBQNjv8L73EJYNIF8pqP mxVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=P9fjlIzeouAfPwThz1Mc4IOnS6qkRAS+Ft9R2AlzTrE=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=QbJY2rXKZYDVDpdxsqdZZ/cvgAutpVrW7oD97QCX3xjIOmJAkfXThL/4DqkHC5pbnU KdgXW1rBE9hYInK0DXuyaupVl+23Qg7wuXEgsb4/m60rxv0XtKAMd5otOEPcGcbcjTv3 x28JxEONElG2BZsZdksddQH8DzUJ91yq7X/u1Ygt09Vm9++pveNlqWfNTBQI2KhaSTLW NbseDbNiUHc/U3rWlZEjvixxQgQBEmNz/LDtqU0rq7o+ylFGy1KYwAqeI/0Ws9wf2BgZ nwGwMiV2qoo8ugBRqAf4zmKNueUKUUtz/FjIdfLvfiKMfT/5URja2+8f6hhQ/G8Oxloi z00w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PDb4pOtd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VvR6YlJm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=M13Ujnjt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-36a42b0718csi49594924eec.51.2026.11.02.23.47.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2026 23:47:59 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PDb4pOtd; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VvR6YlJm; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=M13Ujnjt; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=P9fjlIzeouAfPwThz1Mc4IOnS6qkRAS+Ft9R2AlzTrE=; b=PDb4pOtdwt1fsD Ru0jkSyf44RsXLah2Y4NCRoJnipnia4b7wAX3KF3Q9LuCuM7FgMeOkCL8NpviQRNUZxJbBJ/GEJsY cgk7kxN1vUertspmmytpp1zLIiDP+Fpvt+bP3UnEgwnRW6l7pQ1l3okcios6BE3YYf/d2kv1LXdHf 7So=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xO9FN-000000003AS-3Xxu; Tue, 03 Nov 2026 07:47:57 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xO9FL-000000003A5-3jFS for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 07:47:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I9WavMcTJ2mIlmAG9kwLs6roA5q6Ub3gtEmE1npwAhw=; b=VvR6YlJmKoHggXOd+WCtjSJd3A S0XUY+WAUvWv9PnXKKyqu7EFGdh+KVTxdapoRo2ULBVbbqCWWKmhw3b9KfbjcNqeNyDKaTj7yleJd JxPYsDl1pyjR1uMNWWJDkFCGeDu6m6GK91stJWaRrKxhKR8BrIuE6NkoSoriatcjo1sg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=I9WavMcTJ2mIlmAG9kwLs6roA5q6Ub3gtEmE1npwAhw=; b=M13UjnjtZNuv0KIuyMXXMsN+on rgX5mNajNDGEWBT4OFJBkpFkqZKEc0I/cRRc3L3u24XL2GaD1i2/h9Hq/B/6w3+Wk1X7Badaf0Csl P4oU0r8iC6LllzP/5J7c3kMzSQL/L7krY4iYSZWFTUEbPPTNTyI+0gkd2Uycbq3ybG1w=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xO9FK-000000001c5-24Uh for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 07:47:55 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A37llAW006285 for ; Tue, 3 Nov 2026 08:47:47 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A37llfK006284 for openvpn-devel@lists.sourceforge.net; Tue, 3 Nov 2026 08:47:47 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 3 Nov 2026 08:47:41 +0100 Message-ID: <20261103074747.6269-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru The function has no definition or callers. The declaration was already dangling in 6fbf66fa ("This is the start of the BETA21 branch..."), the oldest commit in the history, so the commit that removed [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xO9FK-000000001c5-24Uh Subject: [Openvpn-devel] [PATCH v1] options: remove dangling pre_pull_default() declaration X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880822465629673550 X-GMAIL-MSGID: 1880822465629673550 From: Razvan Cojocaru The function has no definition or callers. The declaration was already dangling in 6fbf66fa ("This is the start of the BETA21 branch..."), the oldest commit in the history, so the commit that removed the definition predates it. Change-Id: I4bc08f4d7d8e5b33f951a3340df187da7253449e Signed-off-by: Razvan Cojocaru Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2100 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2100 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering diff --git a/src/openvpn/options.h b/src/openvpn/options.h index c58530a..1c908c4 100644 --- a/src/openvpn/options.h +++ b/src/openvpn/options.h @@ -929,8 +929,6 @@ uint64_t permission_mask, uint64_t *option_types_found, struct env_set *es); -void pre_pull_default(struct options *o); - void rol_check_alloc(struct options *options); int parse_line(const char *line, char *p[], const int n, const char *file, const int line_num,