From patchwork Tue Nov 3 12:18:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5576 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:4121:b0:118:2077:975e with SMTP id d33csp541571laa; Tue, 3 Nov 2026 04:19:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AKwUvByRixLBwR+ZqA5rzo1m7Kr1TfKexlpUsy9PcbdKN/9i33KahQ8Wcgk1njVo/yaBXJz0QHgrxEK6Iu0=@openvpn.net X-Received: by 2002:a05:701a:c907:b0:151:6e80:baa9 with SMTP id a92af1059eb24-1ac5a2a138cmr19619243c88.12.1793708377191; Tue, 03 Nov 2026 04:19:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1793708377; cv=none; d=google.com; s=arc-20260327; b=K38LCGYdpq/Yt2QA4C72CRbodA5esSOwPlsJpD0DZhjSzjKK6p6OHugqOaGcvIIihC lfV7yKPBLiUfVre7Iez0LWrxUGp8CgfYS/1fpFysWZYIXsWZZAKDPtaubc5TcA4ljHCY HcfRe4xr4wIdf3yxeYbF5BQFFpveGNxcSxzFu29nAAkKD9q26akFLnN9Bez0PcFq7qDY 2OUJJlW6WGHMEBfIbWNqNGMYbLzxV/qgn7Sd0/o00st4BVxIInNRNj2cyV77IC3n4UF3 ugVVfBfntG9gmDw5VzyMitHGZv0SfK7xj9uxOtLsChR0ktU4O6TOCluDDMNXlr/5HwWR OyWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=IjbnS1iWJdXUKEf8lfUg3TbvBjqdx6fZjaEeF8V2+h4=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=e6sbg3kJTyZOybYPsvgrmDq+HLCMxJV7X1OLQmE31QDORn8m/4fvjlQk0uf/aUo/dd YWfhB7QR1uBqp91yY3rQCaejE9hv2+7vYNxjrCva/s3NPYvUacWCyls56rBomCTYKM3l twMCsQGPCcGE0mT5UD1EEBV89aT2Ky/9vpkCbuKGYsTcG3e67z7S8dgq0eh9EwfHiXMU 9Q8JWkMMvBn1zd8ER6qYQAsi0YyWs7kdTDhR2aLXVxgY+WP1v5V8FFmScRVNHGVlnGEE GeGNa/fl0KTYFlGlO8hJS8Xerj2EOiP9B0ayYJE6tSxJ7wzuCFDTT2nSgu4cd4AjRguW QksQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jheaDbV8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VnPFBWJD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hhI8jVFM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-36a42aecd05si39979692eec.44.2026.11.03.04.19.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2026 04:19:37 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jheaDbV8; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=VnPFBWJD; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=hhI8jVFM; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=IjbnS1iWJdXUKEf8lfUg3TbvBjqdx6fZjaEeF8V2+h4=; b=jheaDbV8zuB+Fv 2hLvD2uIntywYnA7jn+z4naZGO+Rdq2oLQMzhHBXBTzPf26tmHCGA048g/pZ7/LHMk4QsCBBHhvV9 jLymXkdIETPgqj2VI4nV7kridrYRyouwwFjynw1E+ol9qvS9FoZ0vqTVhhmz35BXAIrba3CO5tOtF RmY=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xODUF-000000003DA-3oxK; Tue, 03 Nov 2026 12:19:35 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xODTs-000000003Cs-3YqJ for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 12:19:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mw/W0opyZliHk9XKhgQXpeRqHhv9RzPiv8uITcsO/Rk=; b=VnPFBWJDqwXuIqb2LwsW+iMwff FM1FaKU3BWMYaW5xqtFE1BCkJSJmoERTzcerk7ANlT1YR00m8YM7Hz6165HZ2RVp2cSF22yxK6GFj p6lrbzkgOMHpORzoZgbRumz1JNpQUlX8C0rHKYwnJE6uI4+zfQ1OBy9QnxyDogNLB7bI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mw/W0opyZliHk9XKhgQXpeRqHhv9RzPiv8uITcsO/Rk=; b=hhI8jVFMtptNflSjFfb0Isx2fR m/5/DKkUlPZEJRJKf/MJkHILMHNn/OD0FXIBF8DpUw5OpWl6+N00/uGfTL4cm7Gd1VWWQKf3ByaqY qEM1OC0AJp9OVhWtrS+J+l/95AqxL3CEPgcfsoHMq1jcIvkFsRrl6kGXvenAPQnLwEsg=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xODTr-000000003Dm-0mUH for openvpn-devel@lists.sourceforge.net; Tue, 03 Nov 2026 12:19:12 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A3CJ4ZV002389 for ; Tue, 3 Nov 2026 13:19:04 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A3CJ4QT002386 for openvpn-devel@lists.sourceforge.net; Tue, 3 Nov 2026 13:19:04 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 3 Nov 2026 13:18:58 +0100 Message-ID: <20261103121903.2369-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Razvan Cojocaru get_console_input_systemd() returned without freeing argv on popen failure. Free it right after openvpn_popen(), which no longer needs it. Change-Id: Iad78e78cf51812c392f53cd58b33b54cb99cc6a8 Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xODTr-000000003Dm-0mUH Subject: [Openvpn-devel] [PATCH v1] console_systemd: free argv when openvpn_popen() fails X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1880839555466155276 X-GMAIL-MSGID: 1880839555466155276 From: Razvan Cojocaru get_console_input_systemd() returned without freeing argv on popen failure. Free it right after openvpn_popen(), which no longer needs it. Change-Id: Iad78e78cf51812c392f53cd58b33b54cb99cc6a8 Signed-off-by: Razvan Cojocaru Acked-by: Frank Lichtenheld Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2097 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2097 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Frank Lichtenheld diff --git a/src/openvpn/console_systemd.c b/src/openvpn/console_systemd.c index 9588b95..eaed24e 100644 --- a/src/openvpn/console_systemd.c +++ b/src/openvpn/console_systemd.c @@ -69,7 +69,9 @@ argv_printf_cat(&argv, "--timeout=0"); argv_printf_cat(&argv, "%s", prompt); - if ((std_out = openvpn_popen(&argv, NULL)) < 0) + std_out = openvpn_popen(&argv, NULL); + argv_free(&argv); + if (std_out < 0) { return false; } @@ -81,8 +83,6 @@ } close(std_out); - argv_free(&argv); - return ret; }