From patchwork Mon Nov 9 09:11:32 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5612 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:63cb:10b0:11a:a05e:cb97 with SMTP id w11-n1csp413107lat; Mon, 9 Nov 2026 01:11:56 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErHuiCUGGAJ2X7H5sCuIH7dH5nlkKlKq/zzzFDPQCxpzPpw9F60JCia56kK3oxiOOtRi9RjT99hkvAY=@openvpn.net X-Received: by 2002:a05:693c:60ce:b0:36a:1a7b:d1bb with SMTP id 5a478bee46e88-370f7c8def6mr11197898eec.22.1794215515757; Mon, 09 Nov 2026 01:11:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794215515; cv=none; d=google.com; s=arc-20260327; b=jQ+yQdQGI/U9tNsmyvIR/B7CsvZcwsb4KzLSgv3A53sIw4W+qlofiHjtbKY6ArG9/N no6K5SclIeWzt20PKzzeUndxN/fraMo1MIdHH8tBsTEnPvFEX4PQNHeBuLsDwq4/m3xy J470ILMuU9NO9bth7EDArQm3t4Wg5+03q83rIVtpzcWk2WcBM8q6KO7V/JlzkJ6mtqm7 uZIhB4UzDpixtElIOTezbiMf9shj9x6AosdU0Tu41vY3/txtL38IRjzGCjRgDwCG9igm 4pD67q5VeAexmi5QcfYyaEcHGy1gJ/abmEC9PcFbCZOfSNqOpVx9Tr7b6Sk9r7CC2h6A tR9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=zq3KHIJko2+RBvLTQ9QBxnwTjR/tYTQtlaAFwZJKQ9E=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=TxfK/9Rxp9HBGyTdFAlYHxh3jdNoAuuhfIGLYzZw1uFahn4HbTkIiEZBGFH58qQqm7 NSlu6vYzy19Lf/VO3LrdSRbkz2b1LKlBoNSvTlBAb8acQyyPiXy80TxGxvLorkuwtRWZ wdHGIpU34qmFxzkrjcU/h8ISQna7Tgz1AGNMvAFAlhXRahGGC5pPt999wQyJ9EJDh7Ga uivjl9DuYi9G9Y2GbhzKVDpzLdzRuVSxNbRUj9+K7jqFbXeuxxs9EuVYemSswJSuF5by 6Yn0qFFtyMJJx47Gnwz8cZlzdrllzvS90YDw2ri6nV1gykpXBTSwi/7vU0zv9+rPKA1u CTsA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PcOjT1MD; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="B7EeB3/U"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y3ddYK09; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 5a478bee46e88-37265d0496fsi12779336eec.45.2026.11.09.01.11.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Nov 2026 01:11:55 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=PcOjT1MD; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b="B7EeB3/U"; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=Y3ddYK09; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=zq3KHIJko2+RBvLTQ9QBxnwTjR/tYTQtlaAFwZJKQ9E=; b=PcOjT1MDC4WCrD LoFEeESh31V/4ndrG+4eHYC6xZloWJDK0vWNS1IlJ+/XSFAuzoVeltXpgdFxJXeh0lfzE2RIHdngv 3d/SL36z3kR+CAUaErDcOO1Ldgj5chy+j+hC994Xgp1gWUWahudUoEJqE3MHfZewE/hhfSjYl9EBU UB4=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xQLPt-000000008HP-0mDw; Mon, 09 Nov 2026 09:11:53 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xQLPr-000000008HJ-2CWF for openvpn-devel@lists.sourceforge.net; Mon, 09 Nov 2026 09:11:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sqOVK+VD3Tyft+rPIG2F++qHkCy4Iq3xjHLMccV95gI=; b=B7EeB3/UFCc6Nc2bPc7NlVOZB6 7n1x5vAlatIyKOTJF3YJIUL+lQUvrHonZLWPrKAMIhkJEZYJvYfvOGTmMFVXNdBmTyZbQDpkJoJ2S gxGUqF7xKkkzkoKpMww9eFGxWyI8gw4pHqPZhltXzdwiRnEJxEbr4qsCOSiDsoGXgDwc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sqOVK+VD3Tyft+rPIG2F++qHkCy4Iq3xjHLMccV95gI=; b=Y3ddYK099iECsdmqd/2Mf0W9aC 7JfcFZMiSy6GTGtEzFpbWuuUAk4n9DD8NJHSfvSsio0vt3+QoawoRnsv7I9LzYOSPUrtGNfVMZYNL kGZyZ4afatODIJpDAUMHYFp872W2aylIl7OTF9A3R2w86NFtWW3vL7P7PwkZ+tteqkA4=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xQLPn-000000001eu-0Z1z for openvpn-devel@lists.sourceforge.net; Mon, 09 Nov 2026 09:11:51 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6A99Be42004862 for ; Mon, 9 Nov 2026 10:11:40 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6A99BeoO004861 for openvpn-devel@lists.sourceforge.net; Mon, 9 Nov 2026 10:11:40 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Mon, 9 Nov 2026 10:11:32 +0100 Message-ID: <20261109091139.4816-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-2.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Lev Stipakov initial_rate_limit_init() allocates with ALLOC_OBJ, which does not clear, and assigns every field but warning_displayed. The first period reset assigns it before anything reads it, so nothing misbehav [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xQLPn-000000001eu-0Z1z Subject: [Openvpn-devel] [PATCH v2] reflect_filter: initialise warning_displayed in the rate limiter X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1881371328604410135 X-GMAIL-MSGID: 1881371328604410135 From: Lev Stipakov initial_rate_limit_init() allocates with ALLOC_OBJ, which does not clear, and assigns every field but warning_displayed. The first period reset assigns it before anything reads it, so nothing misbehaves today, but there is no reason to leave a field undefined. Change-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc Signed-off-by: Lev Stipakov Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2146 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2146 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/reflect_filter.c b/src/openvpn/reflect_filter.c index e5226e4..953fff5 100644 --- a/src/openvpn/reflect_filter.c +++ b/src/openvpn/reflect_filter.c @@ -95,6 +95,7 @@ irl->period_length = period_length; irl->curr_period_counter = 0; irl->last_period_reset = 0; + irl->warning_displayed = false; return irl; }