From patchwork Wed Nov 11 18:31:57 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 5674 Return-Path: Delivered-To: patchwork@openvpn.net Received: by 2002:a05:6022:529c:b0:11a:a05e:cb97 with SMTP id x28csp876773lax; Wed, 11 Nov 2026 10:32:14 -0800 (PST) X-Forwarded-Encrypted: i=2; AL+hErEJVfBicHz0dV7cMftUXA9Fpgf+pR0PMcpadeT2wOy3yUKtyJgp9NZB+bhgPBlcS5Gn81e3Rb86neo=@openvpn.net X-Received: by 2002:a05:6830:44a3:b0:805:2785:fad5 with SMTP id 46e09a7af769-860f28de628mr3207900a34.27.1794421934549; Wed, 11 Nov 2026 10:32:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1794421934; cv=none; d=google.com; s=arc-20260327; b=gZH64INNpdIMNad6OsPx+BqpsTUwPvacRlwVP0AwZVP9Gs9HKlNzcxiVQ7yNQ6XwWS 55XLvML4u+ZzwGUzqQKWRywMWRtTOVwoHa5nAgFq4RYkAEmvEvdheCzT+UNf/54xh4Jk bdFrfSsdFBfdzp/U4VvSUc3p0k65eNRgYbEkf2yA11z0RAnNepcuFYjwo5lwhCBZOj/F HAHliNMwtFYfotHcy+G1y/2y+pf52zwEBI91cipWj0cVgzz4ejCKaYXK6DE5z2295AyK I20AEZnIg2R3HVZ6MZSXN6l/mT9iNEEdCPixuMk0zi7PpoEjf8lceXNeDava4+WNG6Zb j9ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=errors-to:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:dkim-signature:dkim-signature; bh=h8YgHkU6CUfMGQpYZvR1xvZStdCyCVQMnbwDmZYeT+M=; fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=; b=aG8FgORTq7RDd4VDvNZr7+ZoelGbvPwjR0Df8LO2KzcEAfR0AGhUIKkPB1+CbrNZLk cfwmo2cxDcgTQsl7eY3CVwi3XvouXjcl1TnJ/wuZlhZCsW6HO/OzeD4r0NSENZmze75G KoPaLhQ1AT6sWe5EHYtiOJY2bPIXNofGpJ9jxqr2TxL00ZWzo8YSxylZoM8tp7t5WuS9 M9wTJH6gx6YpfSljN3wFarQdkWsDW22qkWgAFtXCJFrzjx/MYSEzt4uU1NYZ60J2v5pT LP1qXNCOWv2ZHbtCHDB7RQ31THeL5UF0yCWg/p2VhE0rbn2OgocMn7DBh9TskLjHau+P 4Flg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jvSDO5YA; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EnFrTn5M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jBwtNzEs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7]) by mx.google.com with ESMTPS id 46e09a7af769-860dcbe58bbsi9553662a34.77.2026.11.11.10.32.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2026 10:32:14 -0800 (PST) Received-SPF: pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) client-ip=216.105.38.7; Authentication-Results: mx.google.com; dkim=pass header.i=@lists.sourceforge.net header.s=beta header.b=jvSDO5YA; dkim=neutral (body hash did not verify) header.i=@sourceforge.net header.s=x header.b=EnFrTn5M; dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x header.b=jBwtNzEs; spf=pass (google.com: domain of openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=h8YgHkU6CUfMGQpYZvR1xvZStdCyCVQMnbwDmZYeT+M=; b=jvSDO5YAu3zFec PkHfxJ1k6OUTKZvJYNoeUI2GanMiL9jAL2/CedJ7g0aPJxRnll127V7JKlRsbw5p0jV+mxxVJt4Wd txlEcXAPe+x/lNsm1RnKQqOw+OEsO8pslOEHVgcOlYlJ1BdGEEFOzF+fiRd/y/ON1n+Utk97mKZ8e 3Ss=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.100.1) (envelope-from ) id 1xRD7F-000000007WL-2tcJ; Wed, 11 Nov 2026 18:32:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xRD7D-000000007WF-41uN for openvpn-devel@lists.sourceforge.net; Wed, 11 Nov 2026 18:32:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dyAZ+6ZpM7m6v0Xe7UmijcgZfUVohJsjWoVHEXNBRCg=; b=EnFrTn5Mw6f/BRWCmJLdvuw9b3 oKkIwniZ4oCFnvqQEVCGVQOEMK1m9kx1B4Gfs7Vu17uT5FTwzKsBZTwoC1xLCDuIkuaYr6Z3a1AUT gWdabu/D/ttOEbjpz86BT7EggS5UworrPeo3sF8mdhYfYTEStSiPIURd+LfBDw2zy4Jk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dyAZ+6ZpM7m6v0Xe7UmijcgZfUVohJsjWoVHEXNBRCg=; b=jBwtNzEswpN3KAKg2iLHlVHPzI hUkQrhI8JEliw19rOhjXovPqB6s7zNdXsh1KeP7E5zf7jePtwJeAYIODv5pYowo2WenDBNZ22r4EU EWNODpTR0kLF+o587jS2ltTSpcrShPJ+AiiMf24gGENnJ08KHUW2Hm0hpOAcgoKU90f8=; Received: from [193.149.48.129] (helo=blue.greenie.muc.de) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.100.1) id 1xRD7C-0000000080n-1vb7 for openvpn-devel@lists.sourceforge.net; Wed, 11 Nov 2026 18:32:11 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 6ABIW3BP018736 for ; Wed, 11 Nov 2026 19:32:03 +0100 Received: (from gert@localhost) by blue.greenie.muc.de (8.18.2/8.18.1/Submit) id 6ABIW3Od018735 for openvpn-devel@lists.sourceforge.net; Wed, 11 Nov 2026 19:32:03 +0100 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Wed, 11 Nov 2026 19:31:57 +0100 Message-ID: <20261111183203.18722-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "sfi-spamd-1.hosts.colo.sdot.me", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Frank Lichtenheld Previously both int and unsigned int was used. Change-Id: Ie7228ee95c2b43f9be2bf4c6a9a959af2f729088 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/o [...] Content analysis details: (1.3 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1xRD7C-0000000080n-1vb7 Subject: [Openvpn-devel] [PATCH v1] tun: Make error_flags unsigned consistently X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox X-GMAIL-THRID: 1881587774411021364 X-GMAIL-MSGID: 1881587774411021364 From: Frank Lichtenheld Previously both int and unsigned int was used. Change-Id: Ie7228ee95c2b43f9be2bf4c6a9a959af2f729088 Signed-off-by: Frank Lichtenheld Acked-by: Razvan Cojocaru Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2176 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2176 This mail reflects revision 1 of this Change. Acked-by according to Gerrit (reflected above): Razvan Cojocaru diff --git a/src/openvpn/init.c b/src/openvpn/init.c index 0bb5390..a92967e 100644 --- a/src/openvpn/init.c +++ b/src/openvpn/init.c @@ -1835,7 +1835,7 @@ static bool -do_open_tun(struct context *c, int *error_flags) +do_open_tun(struct context *c, unsigned int *error_flags) { struct gc_arena gc = gc_new(); bool ret = false; @@ -2337,7 +2337,7 @@ bool do_up(struct context *c, bool pulled_options, uint64_t option_types_found) { - int error_flags = 0; + unsigned int error_flags = 0; if (!c->c2.do_up_ran) { reset_coarse_timers(c); @@ -2496,7 +2496,7 @@ do_close_tun(c, true); management_sleep(1); - int error_flags = 0; + unsigned int error_flags = 0; c->c2.did_open_tun = do_open_tun(c, &error_flags); update_time(); @@ -4663,7 +4663,7 @@ * open tun/tap device, ifconfig, run up script, etc. */ if (!(options->up_delay || PULL_DEFINED(options)) && (c->mode == CM_P2P || c->mode == CM_TOP)) { - int error_flags = 0; + unsigned int error_flags = 0; c->c2.did_open_tun = do_open_tun(c, &error_flags); }