From patchwork Thu Dec 20 19:43:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristof Provost via Openvpn-devel X-Patchwork-Id: 650 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 8J8uGeqPHFzcEQAAIUCqbw for ; Fri, 21 Dec 2018 02:02:02 -0500 Received: from proxy8.mail.iad3b.rsapps.net ([172.31.255.6]) by director8.mail.ord1d.rsapps.net with LMTP id uJOJFuqPHFxmZAAAfY0hYg ; Fri, 21 Dec 2018 02:02:02 -0500 Received: from smtp8.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy8.mail.iad3b.rsapps.net with LMTP id qLjKEOqPHFxFBQAAoCsc3g ; Fri, 21 Dec 2018 02:02:02 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp8.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=pass header.d=lists.sourceforge.net; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=vdberg.org; dmarc=pass (p=none; dis=none) header.from=lists.sourceforge.net X-Suspicious-Flag: NO X-Classification-ID: 508b29e0-04ee-11e9-8cdd-5254005eee35-1-1 Received: from [216.105.38.7] ([216.105.38.7:64649] helo=lists.sourceforge.net) by smtp8.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 0B/9D-21509-9EF8C1C5; Fri, 21 Dec 2018 02:02:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:Message-ID:Date:MIME-Version:To:Sender:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=kEuDCwGaQlwLZAb5N8rw+gqYPkUVLMEpOXhlUqRmB64=; b=cs5Wriv0arefTGWQ1OXs34oAfs hRa56Uon86b93cyPKXd8URuox+l0pNgTcOT/QIA8CnxQ0kzxGVuRIIFhptch/0LaU0j85YcCHkSSz gA5MWpWHA1pV1LM1j8KNh29l+6VpSgBXAFzUdmFYLzbyYcDj1nNyULb4DRBJJdPGC+wM=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1gaEo4-0004tY-88; Fri, 21 Dec 2018 07:01:12 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gaEo2-0004tQ-Ti for openvpn-devel@lists.sourceforge.net; Fri, 21 Dec 2018 07:01:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-ID:From:Date:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:To:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Th7xfMzb15KWPhz7aD+p/tGbwacgVIxVOJfgK1woyy8=; b=IJlalAzEMrzcML7+4fDC42ZdP2 dyOWpsfJGFFfbrngMXeIQk7yH/RJVqEOjnjZflRz1mWyRK6DSV5Bo43Rh0X7QmDuca8LobmOYcnWi EDFFOwcgHQrAEx2o8Ac/H9kRSjEYRXW1PMHNMO9YSjb4ZW+qL7X3Mll2qwm4ch8WU9bI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-ID:From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version: Subject:To:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=Th7xfMzb15KWPhz7aD+p/tGbwacgVIxVOJfgK1woyy8=; b=J e1W65sZdxpkhumB2gbyWS3OVMSHBBSr6PES97cvqxJo388lksYT6mrhnIcGxiHc76bKaZjWIzEzt2 GYPWhke+CArYDLbGf6aLPi3v9wKLFNRb9gUOM6vy+OIg4ETMoIAhZRXxKINkG0cs2Uv13A+LodXKt IL1QucHXArRBsP6M=; Received: from majoron.soleus.nu ([94.142.246.140] helo=mx.no-spam-here.com) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1gaEnw-00BGkD-Cc for openvpn-devel@lists.sourceforge.net; Fri, 21 Dec 2018 07:01:10 +0000 Received: by mx.no-spam-here.com (Postfix, from userid 33) id 2E5B342C63; Fri, 21 Dec 2018 07:43:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vdberg.org; s=mail; t=1545374608; bh=8HcaEoMKXWrhC1YiT1dIdY3qSOFUaHCRaUnBGDCzgjc=; h=To:Subject:Date:From:From; b=TOIOj+crPgGqcnLSdiGGLXhVDAHtZH0bTaz2nRaeMRnwJWxojD+/7qmUuAGpyo4gG kztakmiAjL9CvVdZwwwVy+NwbydDmmy9im7yNoopbuC3+Z1UcoIXBdGK+0Tyd/MI7E JCyLMZpT38L2gJlkac/VBg2zAllqVLtpnNndAIBU= To: openvpn-devel@lists.sourceforge.net X-PHP-Originating-Script: 0:rcube.php MIME-Version: 1.0 Date: Fri, 21 Dec 2018 07:43:28 +0100 Message-ID: X-Sender: richard@vdberg.org User-Agent: Roundcube Webmail/1.2.3 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1gaEnw-00BGkD-Cc Subject: [Openvpn-devel] [PATCH] Fix error message when using RHEL init script X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard van den Berg via Openvpn-devel From: Kristof Provost via Openvpn-devel Reply-To: Richard van den Berg Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox In RHEL 7 /etc/sysconfig/network is no longer used (still there but empty). This results in the following error when openvpn starts: Dec 20 09:01:25 localhost openvpn: /etc/rc.d/init.d/openvpn: line 94: [: =: unary operator expected Acked-by: Gert Doering --- distro/rpm/openvpn.init.d.rhel | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/distro/rpm/openvpn.init.d.rhel b/distro/rpm/openvpn.init.d.rhel index cdf3e9de..bfde2216 100755 --- a/distro/rpm/openvpn.init.d.rhel +++ b/distro/rpm/openvpn.init.d.rhel @@ -91,7 +91,7 @@ work=/etc/openvpn . /etc/sysconfig/network # Check that networking is up. -if [ ${NETWORKING} = "no" ] +if [ "${NETWORKING}" = "no" ] then echo "Networking is down" exit 0