From patchwork Wed Apr 17 01:00:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 725 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director9.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id MEirBFkMt1z+GgAAIUCqbw for ; Wed, 17 Apr 2019 07:22:01 -0400 Received: from proxy2.mail.iad3b.rsapps.net ([172.31.255.6]) by director9.mail.ord1d.rsapps.net with LMTP id WHE5AlkMt1z0aQAAalYnBA ; Wed, 17 Apr 2019 07:22:01 -0400 Received: from smtp2.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy2.mail.iad3b.rsapps.net with LMTP id ULzAN1gMt1xpeQAAvAZTew ; Wed, 17 Apr 2019 07:22:00 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp2.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=foxcrypto.com; dmarc=fail (p=none; dis=none) header.from=foxcrypto.com X-Suspicious-Flag: YES X-Classification-ID: 045df310-6103-11e9-a9b1-5254000fbace-1-1 Received: from [216.105.38.7] ([216.105.38.7:50773] helo=lists.sourceforge.net) by smtp2.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 2C/05-08352-85C07BC5; Wed, 17 Apr 2019 07:22:00 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1hGico-0000de-16; Wed, 17 Apr 2019 11:21:10 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hGicm-0000dV-14 for openvpn-devel@lists.sourceforge.net; Wed, 17 Apr 2019 11:21:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Date:Subject:CC:To:From: Sender:Reply-To:Message-ID:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WESxpXUtC5BmYL+jOJ/Rb5ISRuMAfDGrBlYtI/AneiA=; b=ZK+B/LCxVG575at282RizK7ewJ BVWeSbczY/LkF6m8YnbKlH6SJrX3fRNKxu/v0GzJOfrQaDSymKZubh5WNyEkJ5XznJCOLrUaap+Kz ZdrQsTDMbT2Bg3r7UKTF/55jM/XbNeFn8LGtLlHP5//uUtJcbfzBmKdzSW1LGWoQ29G4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Date:Subject:CC:To:From:Sender:Reply-To: Message-ID:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WESxpXUtC5BmYL+jOJ/Rb5ISRuMAfDGrBlYtI/AneiA=; b=Hn3dmZNRrSI4sRcbEYyPSUV50Q Ou961F/Rt/RB750/4damjoQS5GuArZq1my2EfYJYhYBYCAGxVLq9reuGUmmL3LljjS1dK3DM2pXpI XFlDZUl2A4l/Pp332l6rNj4SgXgt1s36QMlN1jOrA6cSeqkNNYiTVMPD4QnBrGo1A6eQ=; Received: from nl-dft-mx-01.fox-it.com ([178.250.144.135]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) id 1hGici-00CPUw-G6 for openvpn-devel@lists.sourceforge.net; Wed, 17 Apr 2019 11:21:07 +0000 From: Steffan Karger To: Date: Wed, 17 Apr 2019 13:00:18 +0200 X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-ClientProxiedBy: FOXDFT52.FOX.local (10.0.0.129) To FOXDFT52.FOX.local (10.0.0.129) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; d=foxcrypto.com; s=NL-DFT-MX-01; c=relaxed/relaxed; h=from:to:cc:subject:date:mime-version:content-type; bh=WESxpXUtC5BmYL+jOJ/Rb5ISRuMAfDGrBlYtI/AneiA=; b=NE/0D+8yXgfmIt9pAbePH11VKUM4Jte0cwrwMdqfxLQzMuvoXklpEZu5W7a5yQDOVGjF4dYX2x2z dTFoLVABCPNSmtO2bIDz2uAgxdx33PCmp714C+keb3ZsGSXeYhdnVZ90qlOpsNiyowGZU+RNg8tr Jr167zyGAMpJ3TX0GJCqGBqRqWIcgM4+U8QDtNP2tsCO+/QYiZSHSuC0UQ4dkfZ6rDqk/nBsqrHv 66DxakC3e4DW37ndpO1LN9ProBTfBPzH28Gp5IhGH1GevkX6xdbO1uAMwtX5fhylYjS8NBmWC/B8 RKRWO7LQaVv1nU4DiZrVjElEP6n0s7OuWmDhfg== X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: t_lpback.sh] -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 1.0 MISSING_MID Missing Message-Id: header X-Headers-End: 1hGici-00CPUw-G6 Subject: [Openvpn-devel] [PATCH] tests: remove dependency on base64 X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffan Karger Errors-To: openvpn-devel-bounces@lists.sourceforge.net Message-Id: X-getmail-retrieved-from-mailbox: Inbox From: Steffan Karger Triggered by the report from Ilya, that if base64 is missing, the tests would still report success: Testing tls-crypt-v2 key generation (max length metadata)..../t_lpback.sh: base64: not found OK PASS: t_lpback.sh The easiest way to fix that, is to remove the dependency on base64 (which is it's current form wouldn't work on OSX anyway, because their base64 doesn't understand "-w0"). Signed-off-by: Steffan Karger Acked-By: Arne Schwabe --- tests/t_lpback.sh | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/t_lpback.sh b/tests/t_lpback.sh index fb43211d..dd6c34e5 100755 --- a/tests/t_lpback.sh +++ b/tests/t_lpback.sh @@ -77,10 +77,15 @@ else echo "OK" fi +# Generate max-length base64 metadata ('A' is 0b000000 in base64) +METADATA="" +for i in $(seq 1 732); do + METADATA="${METADATA}A" +done echo -n "Testing tls-crypt-v2 key generation (max length metadata)..." "${top_builddir}/src/openvpn/openvpn" --tls-crypt-v2 tc-server-key.$$ \ - --tls-crypt-v2-genkey client tc-client-key.$$ \ - $(head -c732 /dev/zero | base64 -w0) >log.$$ 2>&1 + --tls-crypt-v2-genkey client tc-client-key.$$ "${METADATA}" \ + >log.$$ 2>&1 if [ $? != 0 ] ; then echo "FAILED" cat log.$$