From patchwork Mon Nov 20 14:43:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 87 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director4.mail.ord1d.rsapps.net ([172.30.191.6]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id 68kCD1WFE1o/bQAAgoeIoA for ; Mon, 20 Nov 2017 20:45:57 -0500 Received: from proxy15.mail.ord1d.rsapps.net ([172.30.191.6]) by director4.mail.ord1d.rsapps.net (Dovecot) with LMTP id 21v5DlWFE1rxXgAAHDmxtw ; Mon, 20 Nov 2017 20:45:57 -0500 Received: from smtp21.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy15.mail.ord1d.rsapps.net (Dovecot) with LMTP id CsmtDVWFE1p4DwAAAY1PeQ ; Mon, 20 Nov 2017 20:45:57 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp21.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Classification-ID: b7d724e6-ce5d-11e7-ab0b-525400a98691-1-1 Received: from [216.34.181.88] ([216.34.181.88:56475] helo=lists.sourceforge.net) by smtp21.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F7/22-01780-555831A5; Mon, 20 Nov 2017 20:45:57 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-3.v29.ch3.sourceforge.com) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1eGxbe-0007TD-Mc; Tue, 21 Nov 2017 01:44:10 +0000 Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.194] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eGxbe-0007T7-CX for openvpn-devel@lists.sourceforge.net; Tue, 21 Nov 2017 01:44:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KftnnIqDPjw4H1/BJU7cF4ht+mj01PoRREEiRv147D4=; b=RQo/46r3252EHOOXzCX/K5aV4m NFyOFuXH6XzzoQYUNrT1rf6CnEb78kCEhX1QNZdBe578FWRDU5N9KQAfTvkFuC7D4zS/CYnyxuCvG kluO0ToV5QLqfj7b73icyai9HanPACpvkzCookpZlCG70hzd68TlHvsLcWWiErHHD/YQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KftnnIqDPjw4H1/BJU7cF4ht+mj01PoRREEiRv147D4=; b=LyCMUd1dNNg4wgC1gbACWE35jm 1jyKIMBhefnds55eLpqmcVMnGOUnIwShTU4+TyMX7YfZV8XOPufJmpjIRLkJDBgiK3azUKS16ENy3 uTsH6SD4P2ovrSxu636SKtWE0P7SNPXifkn9mk2Oekw7gjD5lpbluYtj4zE2X+oysrsc=; Received: from mail-io0-f194.google.com ([209.85.223.194]) by sfi-mx-4.v28.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) id 1eGxbd-0000AR-Iw for openvpn-devel@lists.sourceforge.net; Tue, 21 Nov 2017 01:44:10 +0000 Received: by mail-io0-f194.google.com with SMTP id w127so17762755iow.11 for ; Mon, 20 Nov 2017 17:44:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KftnnIqDPjw4H1/BJU7cF4ht+mj01PoRREEiRv147D4=; b=ppJgNPlX8kLMrIuvDDR0vBgILQvCyA/hX562bsaQxGHWp9Dr0rq1nAho5LfqSASVvq 1xdRJJ1swPwYZWxpaplkBmz9GuA1dH54c44KkWIMdXpwzevDu1B9HqOudKp1HJhH7QVl vklwwUQ5Yiv9rVzmHd2o+yWa8dKCUEudGBmJ5BqBa4mOcZytiDOSfoQegVOOOgwxXfzh m6lQMfc9Vod+GFSueuYcph3xFvRqiy0aImk3AnR+DfgdMukceJnocb3PKDMbciNornM/ yQWo+zO7z2b0tm4PlNQfUdpyIMf6kM97O9XLD5D0C5TtL33BM2Yqg0D06AYH0HpgNdY3 n4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KftnnIqDPjw4H1/BJU7cF4ht+mj01PoRREEiRv147D4=; b=p4kZy0o+Cux+LxBNJXtu2YVODFuMH4q+kgxhhZKp/kocKn6mZWuoX3ntlx/HCESYl9 pdEHMnF6FXOOkOzJVMJgeDOsIj3UZba2a/cuYu1TF1xb1KylPYZy/wvicUGDrsSHmsuJ yoQO4YbADgylu7C9TpmrWs+gvUZGF2Wi+JAmOdyV/ffad6gtDI/+iJDimqX/v94vT8iN kf8/p5kdibJwvpka/lJlrBhmDq6/ZwakAo1iJI+e+ZmA+bvYYf2jYiH0uRmG/FoAjh+O s4ys8I0BwkUFZXoZQikjUg7OhCJPatrnoqsaMPX2wjRa5HyO6zub8PriwwbORpxWxxR+ p1IA== X-Gm-Message-State: AJaThX4zGTF6YNG3wUzzjF286fhYvQJH7GmZOgoTmSBtjikcmkCOuhr9 afX1wBjjCyC92EyfSfDkil3kzw9A X-Google-Smtp-Source: AGs4zMZGqyKsSBojWb2iyCoYFEfXOKYkXaI0ieeuBM/2BJbNsWtMeC4kaZ1q88SUoVJfx6vmYodNww== X-Received: by 10.107.19.134 with SMTP id 6mr17178296iot.292.1511228643887; Mon, 20 Nov 2017 17:44:03 -0800 (PST) Received: from saturn.home.sansel.ca (CPE40167ea0e1c2-CM788df74daaa0.cpe.net.cable.rogers.com. [99.228.215.92]) by smtp.gmail.com with ESMTPSA id z65sm5177047ioe.52.2017.11.20.17.44.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Nov 2017 17:44:03 -0800 (PST) From: selva.nair@gmail.com To: openvpn-devel@lists.sourceforge.net Date: Mon, 20 Nov 2017 20:43:25 -0500 Message-Id: <1511228605-23207-1-git-send-email-selva.nair@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1494859203-21904-1-git-send-email-selva.nair@gmail.com> References: <1494859203-21904-1-git-send-email-selva.nair@gmail.com> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.223.194 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (selva.nair[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-Headers-End: 1eGxbd-0000AR-Iw Subject: [Openvpn-devel] [PATCH] Correct the declaration of handle in 'struct openvpn_plugin_args_open_return' X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Selva Nair - This is an opaque pointer so the change should not affect existing plugins. But it makes the code consistent and clears up the documentation as the handle pointer is treated as of type "openvpn_plugin_handle_t" in the rest of the code. Signed-off-by: Selva Nair Acked-by: Antonio Quartulli --- v2: no change include/openvpn-plugin.h.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/openvpn-plugin.h.in b/include/openvpn-plugin.h.in index f29b3a0..dfc8e1e 100644 --- a/include/openvpn-plugin.h.in +++ b/include/openvpn-plugin.h.in @@ -355,7 +355,7 @@ struct openvpn_plugin_args_open_in * type_mask = OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_CONNECT) * | OPENVPN_PLUGIN_MASK(OPENVPN_PLUGIN_CLIENT_DISCONNECT) * - * *handle : Pointer to a global plug-in context, created by the plug-in. This pointer + * handle : Pointer to a global plug-in context, created by the plug-in. This pointer * is passed on to the other plug-in calls. * * return_list : used to return data back to OpenVPN. @@ -364,7 +364,7 @@ struct openvpn_plugin_args_open_in struct openvpn_plugin_args_open_return { int type_mask; - openvpn_plugin_handle_t *handle; + openvpn_plugin_handle_t handle; struct openvpn_plugin_string_list **return_list; }; @@ -386,9 +386,9 @@ struct openvpn_plugin_args_open_return * these variables are not actually written to the "official" * environmental variable store of the process. * - * *handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3(). + * handle : Pointer to a global plug-in context, created by the plug-in's openvpn_plugin_open_v3(). * - * *per_client_context : the per-client context pointer which was returned by + * per_client_context : the per-client context pointer which was returned by * openvpn_plugin_client_constructor_v1, if defined. * * current_cert_depth : Certificate depth of the certificate being passed over (only if compiled with ENABLE_CRYPTO defined)