From patchwork Mon Jan 20 21:08:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lev Stipakov X-Patchwork-Id: 968 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director11.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id aA9MFNKxJl4EEQAAIUCqbw for ; Tue, 21 Jan 2020 03:09:54 -0500 Received: from proxy16.mail.iad3b.rsapps.net ([172.31.255.6]) by director11.mail.ord1d.rsapps.net with LMTP id ICbuEdKxJl7gPwAAvGGmqA ; Tue, 21 Jan 2020 03:09:54 -0500 Received: from smtp32.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy16.mail.iad3b.rsapps.net with LMTP id oO9jDNKxJl6qPQAAPj+4aA ; Tue, 21 Jan 2020 03:09:54 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp32.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=gmail.com; dmarc=fail (p=none; dis=none) header.from=gmail.com X-Suspicious-Flag: YES X-Classification-ID: 6749b812-3c25-11ea-afbb-5254006a2e70-1-1 Received: from [216.105.38.7] ([216.105.38.7:58360] helo=lists.sourceforge.net) by smtp32.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id 07/F7-09180-1D1B62E5; Tue, 21 Jan 2020 03:09:54 -0500 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1itoak-0001V4-Ap; Tue, 21 Jan 2020 08:08:54 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1itoai-0001UR-9V for openvpn-devel@lists.sourceforge.net; Tue, 21 Jan 2020 08:08:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=W+sbu4GYSKo7IPj25PuBhzP5Rj5QJPxh15ahGjGwqmM=; b=W3kfT02gh0oGf5vyzndYeHhOIk jNnUCZNJqskogwk6aT+pn4K00ucLtL76t/xJnjJcjzpcrmmVAgYhxTNPwJml3e9+kC5CzAXySrrgR EBUqdpPf2LtGVXrTeOXGtAEie23HaNV9RAYT2waD9uX8a1qniDh7Kd8pe5yFpUK5ExJc=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=W+sbu4GYSKo7IPj25PuBhzP5Rj5QJPxh15ahGjGwqmM=; b=dEMkMhGTnSLgUonM1AbaMmSXmD turpKKOriFcEWclkd8Ng27nAAGOrwII5MvqYhC6gl5f68W/v67TJ8E/2f5/nk5AK2rLC8uXU98hc6 d4kQ0deKK7Um/wTydrErAbzZU1UnBobASOW+OvN5nLVDxMvvz1HIdlAsmnk76wT0uRbU=; Received: from mail-wr1-f68.google.com ([209.85.221.68]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1itoae-00CGFX-2k for openvpn-devel@lists.sourceforge.net; Tue, 21 Jan 2020 08:08:52 +0000 Received: by mail-wr1-f68.google.com with SMTP id z3so2075336wru.3 for ; Tue, 21 Jan 2020 00:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=W+sbu4GYSKo7IPj25PuBhzP5Rj5QJPxh15ahGjGwqmM=; b=Ty2w9XgLPoZwiLtVQLrHcJP+bIBBth9OEywI6PCmgm1pZy4nIABT8dOouNr+x92noj AlvpRhz3rnsc3lWUF/7cN0K67syUkBz9u9+xWZDv2RDMr9MOX47LTNCE5yzYOraCR11S N3b/pbcIT0EtOKRyeFTm86b5HJVyHBYA/s9hWZqtAvJ5eFUfB43Bp2P3YcVaGeeyFp6U Zqz85ZZMgNpeErb/Na15ic+TnPiZN3hugKbdHLDui/j4btfeU4NYg5XGyiP7PPhK/vfl LV/xVlnmLVSeWSqa+h2O7TMGuYxELKopqXB7A1q1VyKmAtSj1SjCMYtjpgN7R6B7SfCZ WQjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=W+sbu4GYSKo7IPj25PuBhzP5Rj5QJPxh15ahGjGwqmM=; b=Xf7oxpScKAHclAXGLdW+W1HB8b+xUCj7WnK07LqI0iihzP3zcuPsXD385NCPRyXERN p41QAJO2aIttolfSR5OIMPSGbXRPNyJ1rfoKxolNQpy60GqCKl7I4KxXlHug08Xlk9Nv QX5c6CQrhjWCtDp7MfzGyHkk4S19oJGff6RQqBaxUkWakdnqIN4DxOKPsXPWag0xK7Yp 7k/pZ8iglCrms+UaLjZjWNQi1FWKQgzfiHFOyrsbLYNUjFXH5uVeb7ltNJgGod0Z4tNA Nyw00EsM9m06yR4tmPJKy/JpB1+fmJ3zAJPv1ovcSODJqw0trrWVTf/sMBYCuWyy6pHl o1XQ== X-Gm-Message-State: APjAAAWDLFB7ZmP3jomVzqwKb6bc2F6QVST/dMqbSzIFO3gewOg9HOTU K9aLOMlRBn5dbX9mJuyBTXv0X/a4QZg= X-Google-Smtp-Source: APXvYqwmw4fahx0VcaY5iYa89mba8osx4wXlIJnUUlSZzRYF6CjnytlUnO4QbJamC3YZCSX3QRbqJQ== X-Received: by 2002:adf:ec4c:: with SMTP id w12mr3954190wrn.124.1579594121005; Tue, 21 Jan 2020 00:08:41 -0800 (PST) Received: from LAPTOP-4L3N7KFS.panoulu.local ([2a00:1d50:3:0:883a:7c51:4138:9a4a]) by smtp.gmail.com with ESMTPSA id i16sm2850849wmb.36.2020.01.21.00.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2020 00:08:40 -0800 (PST) From: Lev Stipakov To: openvpn-devel@lists.sourceforge.net Date: Tue, 21 Jan 2020 10:08:28 +0200 Message-Id: <20200121080828.1310-1-lstipakov@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lstipakov[at]gmail.com) 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: configure.ac] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.68 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.68 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1itoae-00CGFX-2k Subject: [Openvpn-devel] [PATCH] configure.ac: simplify AC_CHECK_FUNCS statements X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lev Stipakov MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Lev Stipakov AC_CHECK_FUNCS checks availability of each function in argument list and defines HAVE_function macro. AC_CHECK_FUNC takes single function as an argument and doesn't automatically define any macros. When we check for availability of a single function and define own macro, it is enough to use AC_CHECK_FUNC. Signed-off-by: Lev Stipakov Acked-by: Arne Schwabe --- configure.ac | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index 98fd39ce..3c057295 100644 --- a/configure.ac +++ b/configure.ac @@ -906,17 +906,17 @@ if test "${with_crypto_library}" = "openssl"; then fi have_crypto_aead_modes="yes" - AC_CHECK_FUNCS( + AC_CHECK_FUNC( [EVP_aes_256_gcm], , - [have_crypto_aead_modes="no"; break] + [have_crypto_aead_modes="no"] ) have_export_keying_material="yes" - AC_CHECK_FUNCS( + AC_CHECK_FUNC( [SSL_export_keying_material], , - [have_export_keying_material="no"; break] + [have_export_keying_material="no"] ) AC_CHECK_FUNCS( @@ -1018,10 +1018,10 @@ elif test "${with_crypto_library}" = "mbedtls"; then ) have_export_keying_material="yes" - AC_CHECK_FUNCS( + AC_CHECK_FUNC( [mbedtls_ssl_conf_export_keys_ext_cb], , - [have_export_keying_material="no"; break] + [have_export_keying_material="no"] ) CFLAGS="${saved_CFLAGS}"