From patchwork Thu May 28 13:46:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Bottomley X-Patchwork-Id: 1129 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director12.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 2LPNBaVN0F7rYAAAIUCqbw for ; Thu, 28 May 2020 19:47:49 -0400 Received: from proxy5.mail.iad3b.rsapps.net ([172.31.255.6]) by director12.mail.ord1d.rsapps.net with LMTP id KCRWA6VN0F4sSwAAIasKDg ; Thu, 28 May 2020 19:47:49 -0400 Received: from smtp20.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy5.mail.iad3b.rsapps.net with LMTP id YJnwOKRN0F4cFQAA13hMnw ; Thu, 28 May 2020 19:47:48 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp20.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=hansenpartnership.com; dkim=fail (signature verification failed) header.d=hansenpartnership.com; dmarc=fail (p=none; dis=none) header.from=hansenpartnership.com X-Suspicious-Flag: YES X-Classification-ID: a175e024-a13d-11ea-ab5a-525400497f28-1-1 Received: from [216.105.38.7] ([216.105.38.7:34200] helo=lists.sourceforge.net) by smtp20.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id A0/EB-22426-2AD40DE5; Thu, 28 May 2020 19:47:47 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jeSEu-0004mu-NV; Thu, 28 May 2020 23:47:08 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeSEt-0004ml-5g for openvpn-devel@lists.sourceforge.net; Thu, 28 May 2020 23:47:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Mime-Version:Content-Type :Date:To:From:Subject:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vDOVVD7nkw3N8gi7YvFRk13dBq8wVHQrRhW11CaPrCE=; b=XBwdZ+9EXXGK+ZRpVkVHxd7eze upP2YyujneLrtLIg7Js6UnqploDUG5MKq1xubwXg5fy4D/RgRJhgENfZgW1+sVcCDrO4aJ0ebcQRy LcY2RulpqS9WL72y78Yg/O02h06qWLIML5h58MewlobFiJksEFiWfpAj1FB9k3lc9QmM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Mime-Version:Content-Type:Date:To:From:Subject: Message-ID:Sender:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=vDOVVD7nkw3N8gi7YvFRk13dBq8wVHQrRhW11CaPrCE=; b=P IbwzPtFuHBscb27UBfZu04s4LlBBjaIoGzLTDTSGA4sdA12ZCWXQb/KFP4py3mosSzAgfWW6EsCEk 1/hwDYoYofi0SsoiWJVJTQ3hCsOeHHTeR5IMchiHr0aFvJSlj5cIgYEmardAEgOwDlNaor7Qr+pWY ZGeQrPgf3e2DHjIk=; Received: from bedivere.hansenpartnership.com ([66.63.167.143]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1jeSEs-00BTKw-1H for openvpn-devel@lists.sourceforge.net; Thu, 28 May 2020 23:47:07 +0000 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 8F8488EE10F for ; Thu, 28 May 2020 16:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1590709613; bh=nm0glBh3g1W7EA60Dehepk6vjhmBVRJJ3CvWrDwm+e8=; h=Subject:From:To:Date:From; b=uEgGs489FToR1l0oOjsL2yAyJi3dI4E3mOB2U1pBxu0fz7ohkpjAU7RwjxBeQZniL 91/+sRekxv8ZC9a584T/WsB88n1uSjTuQGneWn6lbwkfzuqpUpykkKPd3heZ7FO82A 063EwvePXjOc35bMbgLus2lDe1DezK6xIfwqh5Vw= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0XpshLUO0Y5a for ; Thu, 28 May 2020 16:46:53 -0700 (PDT) Received: from [153.66.254.194] (unknown [50.35.76.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 39B8C8EE0F8 for ; Thu, 28 May 2020 16:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1590709613; bh=nm0glBh3g1W7EA60Dehepk6vjhmBVRJJ3CvWrDwm+e8=; h=Subject:From:To:Date:From; b=uEgGs489FToR1l0oOjsL2yAyJi3dI4E3mOB2U1pBxu0fz7ohkpjAU7RwjxBeQZniL 91/+sRekxv8ZC9a584T/WsB88n1uSjTuQGneWn6lbwkfzuqpUpykkKPd3heZ7FO82A 063EwvePXjOc35bMbgLus2lDe1DezK6xIfwqh5Vw= Message-ID: <1590709611.3515.22.camel@HansenPartnership.com> From: James Bottomley To: openvpn-devel@lists.sourceforge.net Date: Thu, 28 May 2020 16:46:51 -0700 X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1jeSEs-00BTKw-1H Subject: [Openvpn-devel] [BUG] test_ncp.c failing X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox I'm getting this failure of test_ncp.c [ RUN ] test_check_ncp_ciphers_list [ ERROR ] --- 0x7d67e8 != 0 [ LINE ] --- test_ncp.c:65: error: Failure! [ FAILED ] test_check_ncp_ciphers_list I'm building under openssl-1.1.0i The problem seems to be openssl uses a mixed case name for the cipher and EVP_CIPHER_name() is case sensitive. Applying the patch below fixes this for openssl and gets make check to pass all tests, but I rather wonder why this isn't part of cipher_kt_name() to prevent this type of problem? James diff --git a/tests/unit_tests/openvpn/test_ncp.c b/tests/unit_tests/openvpn/test_ncp.c index 19432410..f58fa2ea 100644 --- a/tests/unit_tests/openvpn/test_ncp.c +++ b/tests/unit_tests/openvpn/test_ncp.c @@ -48,7 +48,7 @@ static void test_check_ncp_ciphers_list(void **state) { struct gc_arena gc = gc_new(); - bool have_chacha = cipher_kt_get("CHACHA20-POLY1305"); + bool have_chacha = cipher_kt_get(translate_cipher_name_from_openvpn("CHACHA20-POLY1305"));