From patchwork Tue Sep 8 01:15:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gert Doering X-Patchwork-Id: 1422 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.31.255.6]) by backend30.mail.ord1d.rsapps.net with LMTP id 4NUnIq5uV18RPgAAIUCqbw (envelope-from ) for ; Tue, 08 Sep 2020 07:44:46 -0400 Received: from proxy3.mail.iad3b.rsapps.net ([172.31.255.6]) by director8.mail.ord1d.rsapps.net with LMTP id WDQVIq5uV19kXgAAfY0hYg (envelope-from ) for ; Tue, 08 Sep 2020 07:44:46 -0400 Received: from smtp19.gate.iad3b ([172.31.255.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy3.mail.iad3b.rsapps.net with LMTPS id mET9G65uV1/uYQAAM8Wetg (envelope-from ) for ; Tue, 08 Sep 2020 07:44:46 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp19.gate.iad3b.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=greenie.muc.de X-Suspicious-Flag: YES X-Classification-ID: b0e77cb2-f1c8-11ea-9387-525400cbaf6c-1-1 Received: from [216.105.38.7] ([216.105.38.7:47516] helo=lists.sourceforge.net) by smtp19.gate.iad3b.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id FC/4E-25056-DAE675F5; Tue, 08 Sep 2020 07:44:45 -0400 Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kFc2e-00077L-5x; Tue, 08 Sep 2020 11:44:04 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFc2c-00076h-A3 for openvpn-devel@lists.sourceforge.net; Tue, 08 Sep 2020 11:44:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bVK6fRCFasV7GsmQKLMRS+RST2YdA+gJiODl/Jw93T8=; b=LxTSJddgoS6PCXM95dF5h6+k+u QPbRQXcnzoS52ExvlFlDbcp4JDiuMxBqTMfqJoe7oJf+lmmsEw8WmMkV4jNOdO9m4LrbwX/G5dgoT 9Ry8xA4JG8QGvzFagp3KAVfmOkml4vC/k1fAIHyVR6iA0AJkwQ6AJlvocMM56RRmirwM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To:From: Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=bVK6fRCFasV7GsmQKLMRS+RST2YdA+gJiODl/Jw93T8=; b=k P/GKfhbq9rgoxHKCwVQPSl2dgLmP37qpHzrTqQNGJrmEY/3eM/2lWcpsMqcI+Lyl7OCmzeu0RLNKC 49fatoCTEXLD+3GQycNKMeypJkNGQQomcjt3qmWUtKRo/tfdJArzyQGAHvQz0gGEXlC9PoKY/8WFa 0TCKZq8cItRzpYzI=; Received: from dhcp-174.greenie.muc.de ([193.149.48.174] helo=blue.greenie.muc.de) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kFc2P-00Gjox-Px for openvpn-devel@lists.sourceforge.net; Tue, 08 Sep 2020 11:44:02 +0000 Received: from blue.greenie.muc.de (localhost [127.0.0.1]) by blue.greenie.muc.de (8.14.9/8.14.9) with ESMTP id 088BFCbb009320 for ; Tue, 8 Sep 2020 13:15:12 +0200 Received: (from gert@localhost) by blue.greenie.muc.de (8.15.2/8.14.9/Submit) id 088BFCKq009319 for openvpn-devel@lists.sourceforge.net; Tue, 8 Sep 2020 13:15:12 +0200 From: Gert Doering To: openvpn-devel@lists.sourceforge.net Date: Tue, 8 Sep 2020 13:15:11 +0200 Message-Id: <20200908111511.9271-1-gert@greenie.muc.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-Headers-End: 1kFc2P-00Gjox-Px Subject: [Openvpn-devel] [PATCH] Document that --push-remove is generally more suitable than --push-reset X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox It's a long-standing and well-known problem that --push-reset removes "critical" options from the push list (like "topology subnet") which will then lead to non-working client configs. This can not be reasonably fixed, because the list of "critical" options depends on overall server config. So just document the fact, and point people towards --push-remove as a more selective tool. Trac: #29 Signed-off-by: Gert Doering Acked-By: Arne Schwabe Acked-By: David Sommerseth --- doc/man-sections/server-options.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/man-sections/server-options.rst b/doc/man-sections/server-options.rst index f1f0667a..2009953c 100644 --- a/doc/man-sections/server-options.rst +++ b/doc/man-sections/server-options.rst @@ -530,6 +530,14 @@ fast hardware. SSL/TLS authentication must be used in this mode. ``--client-config-dir`` configuration file. This option will ignore ``--push`` options at the global config file level. + *NOTE*: ``--push-reset`` is very thorough: it will remove almost + all options from the list of to-be-pushed options. In many cases, + some of these options will need to be re-configured afterwards - + specifically, ``--topology subnet`` and ``--route-gateway`` will get + lost and this will break client configs in many cases. Thus, for most + purposes, ``--push-remove`` is better suited to selectively remove + push options for individual clients. + --server args A helper directive designed to simplify the configuration of OpenVPN's server mode. This directive will set up an OpenVPN server which will