From patchwork Mon Dec 4 21:57:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antonio Quartulli X-Patchwork-Id: 132 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director4.mail.ord1d.rsapps.net ([172.27.255.59]) by backend31.mail.ord1d.rsapps.net (Dovecot) with LMTP id a7kMEzdgJlo6XAAAgoeIoA for ; Tue, 05 Dec 2017 04:00:39 -0500 Received: from proxy8.mail.iad3a.rsapps.net ([172.27.255.59]) by director4.mail.ord1d.rsapps.net (Dovecot) with LMTP id m5sKDTdgJlq5bQAAHDmxtw ; Tue, 05 Dec 2017 04:00:39 -0500 Received: from smtp2.gate.iad3a ([172.27.255.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy8.mail.iad3a.rsapps.net (Dovecot) with LMTP id Yy66AjdgJlrwWQAAsBr/qg ; Tue, 05 Dec 2017 04:00:39 -0500 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.34.181.88] Authentication-Results: smtp2.gate.iad3a.rsapps.net; iprev=pass policy.iprev="216.34.181.88"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dmarc=none (p=nil; dis=none) header.from=unstable.cc X-Classification-ID: c36c8790-d99a-11e7-9828-525400de56ae-1-1 Received: from [216.34.181.88] ([216.34.181.88:16118] helo=lists.sourceforge.net) by smtp2.gate.iad3a.rsapps.net (envelope-from ) (ecelerity 4.2.1.56364 r(Core:4.2.1.14)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id F5/D4-28214-630662A5; Tue, 05 Dec 2017 04:00:38 -0500 Received: from localhost ([127.0.0.1] helo=sfs-ml-2.v29.ch3.sourceforge.com) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.89) (envelope-from ) id 1eM93V-0004At-1m; Tue, 05 Dec 2017 08:58:21 +0000 Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1eM93T-0004A3-Fz for openvpn-devel@lists.sourceforge.net; Tue, 05 Dec 2017 08:58:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gD73fvYrBQci6iLg35krcJTrYXlRmX2BOkz3gQ4PVrs=; b=Rm5I18gzbV/ZcccPBg7TNeZufj jBhK7fOL0n4ftWBJptLma6LrxxJKmR0+fBpRERJOhEFzMX+uZxQVf55IGhO381Am6JRfD4j/k8JD8 h0ew418VzlZlfvU3zMGpIkyH3cjQRGiJZIabdu6mqmQi2coa7BK5OEgMTLpDvJup+UYA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version: Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gD73fvYrBQci6iLg35krcJTrYXlRmX2BOkz3gQ4PVrs=; b=hnlGDKf+hE9K3Ht3THTf+YsvuS h3OeCuQn4peAfrXACe4vkqSU1RsE0yrvFVz46QuwY6U21YSyZzfjYdohHZ/iBDDjZ3cUuI6JuuwfX uMX6SAicItAzj9sy9wktE34X7e1Gx6wawxnHtvmpFanKMwqtar8/E5DwSc/0ksWHIzcc=; Received: from s2.neomailbox.net ([5.148.176.60]) by sfi-mx-3.v28.ch3.sourceforge.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) id 1eM93N-0005LE-7z for openvpn-devel@lists.sourceforge.net; Tue, 05 Dec 2017 08:58:19 +0000 From: Antonio Quartulli To: openvpn-devel@lists.sourceforge.net Date: Tue, 5 Dec 2017 16:57:11 +0800 Message-Id: <20171205085711.25075-1-a@unstable.cc> X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [5.148.176.60 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 AWL AWL: Adjusted score from AWL reputation of From: address X-Headers-End: 1eM93N-0005LE-7z Subject: [Openvpn-devel] [PATCH] mbedtls: fix typ0 in comment X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Antonio Quartulli MIME-Version: 1.0 Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox From: Antonio Quartulli the function used to set the verify callback in mbedTLS is actually called mbedtls_ssl_conf_verify() and it is invoked in key_state_ssl_init(). Fix comment accordingly. Signed-off-by: Antonio Quartulli Acked-by: Steffan Karger Signed-off-by: Antonio Quartulli <antonio@openvpn.net>
--- src/openvpn/ssl_verify_mbedtls.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/openvpn/ssl_verify_mbedtls.h b/src/openvpn/ssl_verify_mbedtls.h index 8b0a5ae9..2fba362f 100644 --- a/src/openvpn/ssl_verify_mbedtls.h +++ b/src/openvpn/ssl_verify_mbedtls.h @@ -48,9 +48,9 @@ typedef mbedtls_x509_crt openvpn_x509_cert_t; * This callback function is called when a new TLS session is being setup to * determine whether the remote OpenVPN peer's certificate is allowed to * connect. It is called for once for every certificate in the chain. The - * callback functionality is configured in the \c init_ssl() function, which - * calls the mbed TLS library's \c ssl_set_verify_callback() function with \c - * verify_callback() as its callback argument. + * callback functionality is configured in the \c key_state_ssl_init() function, + * which calls the mbed TLS library's \c mbedtls_ssl_conf_verify() function with + * \c verify_callback() as its callback argument. * * It checks *flags and registers the certificate hash. If these steps succeed, * it calls the \c verify_cert() function, which performs OpenVPN-specific