From patchwork Mon Sep 14 23:29:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Openvpn-devel] Allow --dhcp-option in config file when windows-driver is wintun X-Patchwork-Submitter: Selva Nair X-Patchwork-Id: 1452 Message-Id: <1600126181-16364-1-git-send-email-selva.nair@gmail.com> To: openvpn-devel@lists.sourceforge.net Date: Mon, 14 Sep 2020 19:29:41 -0400 From: selva.nair@gmail.com List-Id: From: Selva Nair When wintun is in use we mutate ip_win32_type to NETSH and then complain that ip-win32 option should be dynamic or adaptive if any --dhcp-option directive is present in the config file. This causes a fatal error. How to reproduce: specify a --dhcp-option in the config and change the --windows-driver to wintun. Fix this behaviour. A typo in the message is also corrected. Signed-off-by: Selva Nair Acked-by: Lev Stipakov --- src/openvpn/options.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 8bf82c5..4b22d3d 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -2181,10 +2181,11 @@ options_postprocess_verify_ce(const struct options *options, const struct connec } if (options->tuntap_options.dhcp_options + && options->windows_driver != WINDOWS_DRIVER_WINTUN && options->tuntap_options.ip_win32_type != IPW32_SET_DHCP_MASQ && options->tuntap_options.ip_win32_type != IPW32_SET_ADAPTIVE) { - msg(M_USAGE, "--dhcp-options requires --ip-win32 dynamic or adaptive"); + msg(M_USAGE, "--dhcp-option requires --ip-win32 dynamic or adaptive"); } if (options->windows_driver == WINDOWS_DRIVER_WINTUN && dev != DEV_TYPE_TUN)