From patchwork Fri Oct 9 02:46:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steffan Karger X-Patchwork-Id: 1510 Return-Path: Delivered-To: patchwork@openvpn.net Delivered-To: patchwork@openvpn.net Received: from director8.mail.ord1d.rsapps.net ([172.30.191.6]) by backend30.mail.ord1d.rsapps.net with LMTP id mK9yCaBxgF8RGAAAIUCqbw (envelope-from ) for ; Fri, 09 Oct 2020 10:20:16 -0400 Received: from proxy10.mail.ord1d.rsapps.net ([172.30.191.6]) by director8.mail.ord1d.rsapps.net with LMTP id GJgtCaBxgF8IeQAAfY0hYg (envelope-from ) for ; Fri, 09 Oct 2020 10:20:16 -0400 Received: from smtp37.gate.ord1d ([172.30.191.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by proxy10.mail.ord1d.rsapps.net with LMTPS id KIjOCKBxgF+/RAAAfSg8FQ (envelope-from ) for ; Fri, 09 Oct 2020 10:20:16 -0400 X-Spam-Threshold: 95 X-Spam-Score: 0 X-Spam-Flag: NO X-Virus-Scanned: OK X-Orig-To: openvpnslackdevel@openvpn.net X-Originating-Ip: [216.105.38.7] Authentication-Results: smtp37.gate.ord1d.rsapps.net; iprev=pass policy.iprev="216.105.38.7"; spf=pass smtp.mailfrom="openvpn-devel-bounces@lists.sourceforge.net" smtp.helo="lists.sourceforge.net"; dkim=fail (signature verification failed) header.d=sourceforge.net; dkim=fail (signature verification failed) header.d=sf.net; dkim=fail (signature verification failed) header.d=karger-me.20150623.gappssmtp.com; dmarc=fail (p=none; dis=none) header.from=karger.me X-Suspicious-Flag: YES X-Classification-ID: 8c91efc0-0a3a-11eb-9585-525400a11cf3-1-1 Received: from [216.105.38.7] ([216.105.38.7:50356] helo=lists.sourceforge.net) by smtp37.gate.ord1d.rsapps.net (envelope-from ) (ecelerity 4.2.38.62370 r(:)) with ESMTPS (cipher=DHE-RSA-AES256-GCM-SHA384) id EB/99-22693-F91708F5; Fri, 09 Oct 2020 10:20:15 -0400 Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kQtFA-0001s1-Vv; Fri, 09 Oct 2020 14:19:36 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQtF9-0001rp-6b for openvpn-devel@lists.sourceforge.net; Fri, 09 Oct 2020 14:19:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C5XJENSiKUwJ6DAFY7CHJN3+Ch/I4T+rlWm2Zi2K/D0=; b=ipEqL5J0rkT73gDWTcx2QAaVWf lhYP0D0FyZea0yw+48YDtDXgQTsECZSbSKBUWlr+fthgsywdFZUouvnzqSQC4NiQrR/dyBfjyxO5w NjKoVlhTA7v5Or3i6LwnRFIrDcVx/wTf/ULpsv8AU4HEHQpFYkrr0ogztmFSTALzmNDA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:Cc:To:From :Sender:Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive; bh=C5XJENSiKUwJ6DAFY7CHJN3+Ch/I4T+rlWm2Zi2K/D0=; b=g HQg3RYh60qH3ZIpFyKiNVbXRoZilmWw9XpdqaBKzHOA/bWjblCRikKQ/xozNofME9gbtsv9qyL0x3 SspuHaltUFZmRkOKgvk53WIA8tumZQajU+QoSWkcjyzlrvgLtGbX3LGeSIlVxIid3wzE/6vymfi9R s7uwtUgdRx8MFJg8=; Received: from mail-wr1-f68.google.com ([209.85.221.68]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1kQtF1-008XmB-9k for openvpn-devel@lists.sourceforge.net; Fri, 09 Oct 2020 14:19:34 +0000 Received: by mail-wr1-f68.google.com with SMTP id e18so10475267wrw.9 for ; Fri, 09 Oct 2020 07:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karger-me.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C5XJENSiKUwJ6DAFY7CHJN3+Ch/I4T+rlWm2Zi2K/D0=; b=fLJXxJxaka2hhOnfjCYjdL+PG/Ox1pBAlG710rRtZWigGNxDWBsWxhTagp5T0DXo85 uycouUL1i8zhAdEaZ4kt0/2WO9veaFs/jAjj4ldRkVuNVomqa5sI2DU9zwQPnnwwpVVT BSRZp4Fv7WKgPxaHZ7g78L4+8Hu8HDUxLp4UcBEk0Jv5OyYz5A2NukwRWzQ5RUNFvYKs 8sjW/H62F2KE/vEOrWc3WpG6z2bchyQKqqZqJuKoGFbofWO74/kaolz8a2kakSVZO8yP uVUS3i+aq0CbyH/nSH5/mKY37bK9fh/uMjOFjrIFYrnSkBGbyyR2dJ6k8Aeu+W9UAem4 mXig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=C5XJENSiKUwJ6DAFY7CHJN3+Ch/I4T+rlWm2Zi2K/D0=; b=lS06G/iJm7k/0ZliTzij3lugcwYBcVecBAH9Voss02S19Mh/d4ScTl+iXYcvJmZ0qa cDuZew1KhwqdTlwWjp0WQGq0rrYIzpLrugvXD/FBXtRgZXiTm6FYIuYh3Z9YqpJdFfM2 QyLhXRF26Fd7SOpFE83bW7tPv0wSJxsJatzOM3AhYtMIbkClbCAm0kiuW+a//NLu9XH5 hw88gD3l/baZehTiwSfx7n6gpha+aQCiZS2c+TPJmgv/FCGtuBgU0xVfFf62rDA0/iwY ao67DgvJ5/3tyQauJr78HHY09K0NiKU8dPxbSvS5v7Tt511pcgxaa/Z7vmWeH1RYz23T Xlvg== X-Gm-Message-State: AOAM530gY1y2Ygv+v383JEJtN8+BkpIEaAstzTtsEwociye+JDettr+U XKz4WGKIf4KVQsrOnwXpIfRgdtKdGtmjEX8L X-Google-Smtp-Source: ABdhPJzWvES3pkdoAWZg3A3T+W5oYcPP9rhOjpXlzwtEkfILV9czTcWSEoPI7J/7AK6WnPYLUy62gw== X-Received: by 2002:a17:906:3751:: with SMTP id e17mr7838227ejc.241.1602251174302; Fri, 09 Oct 2020 06:46:14 -0700 (PDT) Received: from luna.fritz.box ([2001:985:e54:1:f923:d0d0:b8dd:5bfa]) by smtp.gmail.com with ESMTPSA id mh2sm6479166ejb.30.2020.10.09.06.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 06:46:13 -0700 (PDT) From: Steffan Karger To: openvpn-devel@lists.sourceforge.net Date: Fri, 9 Oct 2020 15:46:03 +0200 Message-Id: <20201009134603.36263-1-steffan@karger.me> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.68 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.68 listed in list.dnswl.org] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: karger.me] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-Headers-End: 1kQtF1-008XmB-9k Subject: [Openvpn-devel] [PATCH] networking_iproute2: fix memory leak in net_iface_mtu_set() X-BeenThere: openvpn-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openvpn-devel-bounces@lists.sourceforge.net X-getmail-retrieved-from-mailbox: Inbox ASAN yelled at me that someone forgot to call argv_free(). Fix that. Signed-off-by: Steffan Karger Acked-by: Antonio Quartulli --- src/openvpn/networking_iproute2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/openvpn/networking_iproute2.c b/src/openvpn/networking_iproute2.c index f3b9c614..3b460527 100644 --- a/src/openvpn/networking_iproute2.c +++ b/src/openvpn/networking_iproute2.c @@ -88,6 +88,8 @@ net_iface_mtu_set(openvpn_net_ctx_t *ctx, const char *iface, uint32_t mtu) argv_msg(M_INFO, &argv); openvpn_execve_check(&argv, ctx->es, S_FATAL, "Linux ip link set failed"); + argv_free(&argv); + return 0; }