| Message ID | 20180114140627.25331-1-chipitsine@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [Openvpn-devel] travis-ci: modify openssl build script to support openssl-1.1.0 | expand |
Hi, On 14-01-18 15:06, Ilya Shipitsin wrote: > no-multilib is only supported on openssl-1.0.X, do not use it > if OPENSSL_VERSION is 1.1.0 > > Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com> > --- > .travis/build-deps.sh | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh > index bc538853..1761932e 100755 > --- a/.travis/build-deps.sh > +++ b/.travis/build-deps.sh > @@ -110,8 +110,9 @@ build_openssl_mingw () { > export TARGET=mingw64 > fi > > - ./Configure --cross-compile-prefix=${CHOST}- shared \ > - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc > + ./Configure --cross-compile-prefix=${CHOST}- shared ${TARGET} \ > + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo "no-multilib") \ > + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc > make install > ) > } > Do we need no-multilib for 1.0.x builds? If not, I'd prefer to just get rid of it. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
2018-01-14 21:05 GMT+05:00 Steffan Karger <steffan@karger.me>: > Hi, > > On 14-01-18 15:06, Ilya Shipitsin wrote: > > no-multilib is only supported on openssl-1.0.X, do not use it > > if OPENSSL_VERSION is 1.1.0 > > > > Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com> > > --- > > .travis/build-deps.sh | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh > > index bc538853..1761932e 100755 > > --- a/.travis/build-deps.sh > > +++ b/.travis/build-deps.sh > > @@ -110,8 +110,9 @@ build_openssl_mingw () { > > export TARGET=mingw64 > > fi > > > > - ./Configure --cross-compile-prefix=${CHOST}- shared \ > > - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" > --openssldir="${PREFIX}" -static-libgcc > > + ./Configure --cross-compile-prefix=${CHOST}- shared ${TARGET} \ > > + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo "no-multilib") > \ > > + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" > -static-libgcc > > make install > > ) > > } > > > > Do we need no-multilib for 1.0.x builds? If not, I'd prefer to just get > rid of it. > it came from windows installer. let me build windows installer without no-multilib and test > > -Steffan > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > <div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2018-01-14 21:05 GMT+05:00 Steffan Karger <span dir="ltr"><<a href="mailto:steffan@karger.me" target="_blank">steffan@karger.me</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br> <span class=""><br> On 14-01-18 15:06, Ilya Shipitsin wrote:<br> > no-multilib is only supported on openssl-1.0.X, do not use it<br> > if OPENSSL_VERSION is 1.1.0<br> ><br> > Signed-off-by: Ilya Shipitsin <<a href="mailto:chipitsine@gmail.com">chipitsine@gmail.com</a>><br> > ---<br> > .travis/build-deps.sh | 5 +++--<br> > 1 file changed, 3 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh<br> > index bc538853..1761932e 100755<br> > --- a/.travis/build-deps.sh<br> > +++ b/.travis/build-deps.sh<br> > @@ -110,8 +110,9 @@ build_openssl_mingw () {<br> > export TARGET=mingw64<br> > fi<br> ><br> > - ./Configure --cross-compile-prefix=${<wbr>CHOST}- shared \<br> > - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc<br> > + ./Configure --cross-compile-prefix=${<wbr>CHOST}- shared ${TARGET} \<br> > + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo "no-multilib") \<br> > + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc<br> > make install<br> > )<br> > }<br> ><br> <br> </span>Do we need no-multilib for 1.0.x builds? If not, I'd prefer to just get<br> rid of it.<br></blockquote><div><br></div><div>it came from windows installer.</div><div>let me build windows installer without no-multilib and test<br></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> -Steffan<br> <br> ------------------------------<wbr>------------------------------<wbr>------------------<br> Check out the vibrant tech community on one of the world's most<br> engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br> ______________________________<wbr>_________________<br> Openvpn-devel mailing list<br> <a href="mailto:Openvpn-devel@lists.sourceforge.net">Openvpn-devel@lists.<wbr>sourceforge.net</a><br> <a href="https://lists.sourceforge.net/lists/listinfo/openvpn-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/openvpn-devel</a><br> </blockquote></div><br></div></div> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
I've built an installer without "no-multilib" and tested on both x86 and x64. 2018-01-14 23:33 GMT+05:00 Илья Шипицин <chipitsine@gmail.com>: > > > 2018-01-14 21:05 GMT+05:00 Steffan Karger <steffan@karger.me>: > >> Hi, >> >> On 14-01-18 15:06, Ilya Shipitsin wrote: >> > no-multilib is only supported on openssl-1.0.X, do not use it >> > if OPENSSL_VERSION is 1.1.0 >> > >> > Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com> >> > --- >> > .travis/build-deps.sh | 5 +++-- >> > 1 file changed, 3 insertions(+), 2 deletions(-) >> > >> > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh >> > index bc538853..1761932e 100755 >> > --- a/.travis/build-deps.sh >> > +++ b/.travis/build-deps.sh >> > @@ -110,8 +110,9 @@ build_openssl_mingw () { >> > export TARGET=mingw64 >> > fi >> > >> > - ./Configure --cross-compile-prefix=${CHOST}- shared \ >> > - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" >> --openssldir="${PREFIX}" -static-libgcc >> > + ./Configure --cross-compile-prefix=${CHOST}- shared ${TARGET} >> \ >> > + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo >> "no-multilib") \ >> > + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" >> -static-libgcc >> > make install >> > ) >> > } >> > >> >> Do we need no-multilib for 1.0.x builds? If not, I'd prefer to just get >> rid of it. >> > > it came from windows installer. > let me build windows installer without no-multilib and test > > > >> >> -Steffan >> >> ------------------------------------------------------------ >> ------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> Openvpn-devel mailing list >> Openvpn-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/openvpn-devel >> > > <div dir="ltr">I've built an installer without "no-multilib" and tested on both x86 and x64.<br></div><div class="gmail_extra"><br><div class="gmail_quote">2018-01-14 23:33 GMT+05:00 Илья Шипицин <span dir="ltr"><<a href="mailto:chipitsine@gmail.com" target="_blank">chipitsine@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">2018-01-14 21:05 GMT+05:00 Steffan Karger <span dir="ltr"><<a href="mailto:steffan@karger.me" target="_blank">steffan@karger.me</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br> <span><br> On 14-01-18 15:06, Ilya Shipitsin wrote:<br> > no-multilib is only supported on openssl-1.0.X, do not use it<br> > if OPENSSL_VERSION is 1.1.0<br> ><br> > Signed-off-by: Ilya Shipitsin <<a href="mailto:chipitsine@gmail.com" target="_blank">chipitsine@gmail.com</a>><br> > ---<br> > .travis/build-deps.sh | 5 +++--<br> > 1 file changed, 3 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh<br> > index bc538853..1761932e 100755<br> > --- a/.travis/build-deps.sh<br> > +++ b/.travis/build-deps.sh<br> > @@ -110,8 +110,9 @@ build_openssl_mingw () {<br> > export TARGET=mingw64<br> > fi<br> ><br> > - ./Configure --cross-compile-prefix=${CHOST<wbr>}- shared \<br> > - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc<br> > + ./Configure --cross-compile-prefix=${CHOST<wbr>}- shared ${TARGET} \<br> > + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo "no-multilib") \<br> > + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc<br> > make install<br> > )<br> > }<br> ><br> <br> </span>Do we need no-multilib for 1.0.x builds? If not, I'd prefer to just get<br> rid of it.<br></blockquote><div><br></div></div></div><div>it came from windows installer.</div><div>let me build windows installer without no-multilib and test<br></div><span class=""><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> -Steffan<br> <br> ------------------------------<wbr>------------------------------<wbr>------------------<br> Check out the vibrant tech community on one of the world's most<br> engaging tech sites, Slashdot.org! <a href="http://sdm.link/slashdot" rel="noreferrer" target="_blank">http://sdm.link/slashdot</a><br> ______________________________<wbr>_________________<br> Openvpn-devel mailing list<br> <a href="mailto:Openvpn-devel@lists.sourceforge.net" target="_blank">Openvpn-devel@lists.sourceforg<wbr>e.net</a><br> <a href="https://lists.sourceforge.net/lists/listinfo/openvpn-devel" rel="noreferrer" target="_blank">https://lists.sourceforge.net/<wbr>lists/listinfo/openvpn-devel</a><br> </blockquote></span></div><br></div></div> </blockquote></div><br></div> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
diff --git a/.travis/build-deps.sh b/.travis/build-deps.sh index bc538853..1761932e 100755 --- a/.travis/build-deps.sh +++ b/.travis/build-deps.sh @@ -110,8 +110,9 @@ build_openssl_mingw () { export TARGET=mingw64 fi - ./Configure --cross-compile-prefix=${CHOST}- shared \ - ${TARGET} no-multilib no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc + ./Configure --cross-compile-prefix=${CHOST}- shared ${TARGET} \ + $([[ ${OPENSSL_VERSION} == "1.0."* ]] && echo "no-multilib") \ + no-capieng --prefix="${PREFIX}" --openssldir="${PREFIX}" -static-libgcc make install ) }
no-multilib is only supported on openssl-1.0.X, do not use it if OPENSSL_VERSION is 1.1.0 Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com> --- .travis/build-deps.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)