Message ID | 20210826100221.1378-1-chipitsine@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [Openvpn-devel] CI: github actions: keep "pdb" in artifacts | expand |
Patch is missing SOB line, but I guess this can be fixed by the
committer, if needed?
Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158
so that PDBs are indeed stored as artifacts.
Acked-by: Lev Stipakov <lstipakov@gmail.com>
Sorry, I missed "signed off by". Please add during commit On Thu, Aug 26, 2021, 3:20 PM Lev Stipakov <lstipakov@gmail.com> wrote: > Patch is missing SOB line, but I guess this can be fixed by the > committer, if needed? > > Checked https://github.com/chipitsine/openvpn/actions/runs/1108264158 > so that PDBs are indeed stored as artifacts. > > Acked-by: Lev Stipakov <lstipakov@gmail.com> > <div dir="auto">Sorry, I missed "signed off by". Please add during commit</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 26, 2021, 3:20 PM Lev Stipakov <<a href="mailto:lstipakov@gmail.com">lstipakov@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Patch is missing SOB line, but I guess this can be fixed by the<br> committer, if needed?<br> <br> Checked <a href="https://github.com/chipitsine/openvpn/actions/runs/1108264158" rel="noreferrer noreferrer" target="_blank">https://github.com/chipitsine/openvpn/actions/runs/1108264158</a><br> so that PDBs are indeed stored as artifacts.<br> <br> Acked-by: Lev Stipakov <<a href="mailto:lstipakov@gmail.com" target="_blank" rel="noreferrer">lstipakov@gmail.com</a>><br> </blockquote></div>
SoB added, no further tests. Your patch has been applied to the master branch. commit 9da733751ce80b2226ef19923365bd3102cfbd47 Author: Ilya Shipitsin Date: Thu Aug 26 15:02:21 2021 +0500 CI: github actions: keep pdb in artifacts Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com> Acked-by: Lev Stipakov <lstipakov@gmail.com> Message-Id: <20210826100221.1378-1-chipitsine@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22769.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
Hi, On Sat, Sep 11, 2021 at 06:50:31PM +0200, Gert Doering wrote: > SoB added, no further tests. > > Your patch has been applied to the master branch. > > commit 9da733751ce80b2226ef19923365bd3102cfbd47 > Author: Ilya Shipitsin > Date: Thu Aug 26 15:02:21 2021 +0500 As requested by Lev, also applied to release/2.5 commit fb3661e6690bc2a32b8a35e2451bf256f3a429ee (HEAD -> release/2.5) Author: Ilya Shipitsin <chipitsine@gmail.com> Date: Thu Aug 26 15:02:21 2021 +0500 CI: github actions: keep "pdb" in artifacts gert
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index b2c16449..4c963114 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -227,3 +227,4 @@ jobs: path: | ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.exe ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.dll + ${{ matrix.plat }}-Output/${{env.BUILD_CONFIGURATION}}/*.pdb \ No newline at end of file