| Message ID | 20230206130846.63415-1-frank@lichtenheld.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [Openvpn-devel] configure: fix formatting of --disable-lz4 and --enable-comp-stub | expand |
Acked-by: Gert Doering <gert@greenie.muc.de> "Makes sense". Before: --disable-lzo disable LZO compression support [default=yes] --disable-lz4 Disable LZ4 compression support --enable-comp-stub Don't compile compression support but still allow limited interoperability with compression-enabled peers After: --disable-lzo disable LZO compression support [default=yes] --disable-lz4 disable LZ4 compression support [default=yes] --enable-comp-stub disable compression support but still allow limited interoperability with compression-enabled peers ("default=yes" is still confusing - does that mean "enabled by default" or "disabled=yes by default"?, but that seems to be "the autoconf way") Your patch has been applied to the master and release/2.6 branch. commit 24e1d8ff87b189247d56261a9497b1f509b286df (master) commit 91da6b9463745635b75df171678ab54b5dcdb0de (release/2.6) Author: Frank Lichtenheld Date: Mon Feb 6 14:08:46 2023 +0100 configure: fix formatting of --disable-lz4 and --enable-comp-stub Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20230206130846.63415-1-frank@lichtenheld.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26156.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/configure.ac b/configure.ac index acfa4bc1..7ce4c826 100644 --- a/configure.ac +++ b/configure.ac @@ -67,14 +67,16 @@ AC_ARG_ENABLE( [enable_lzo="yes"] ) -AC_ARG_ENABLE(lz4, - [ --disable-lz4 Disable LZ4 compression support], +AC_ARG_ENABLE( + [lz4], + [AS_HELP_STRING([--disable-lz4], [disable LZ4 compression support @<:@default=yes@:>@])], [enable_lz4="$enableval"], [enable_lz4="yes"] ) -AC_ARG_ENABLE(comp-stub, - [ --enable-comp-stub Don't compile compression support but still allow limited interoperability with compression-enabled peers], +AC_ARG_ENABLE( + [comp-stub], + [AS_HELP_STRING([--enable-comp-stub], [disable compression support but still allow limited interoperability with compression-enabled peers @<:@default=no@:>@])], [enable_comp_stub="$enableval"], [enable_comp_stub="no"] )
Make consistent with the other options. Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com> --- configure.ac | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) A small issue I noticed when staring at configure.ac for "enable DCO by default" patch.