[Openvpn-devel] msvc-generate: include version.m4.in in tarball

Message ID 20230527095504.17915-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel] msvc-generate: include version.m4.in in tarball | expand

Commit Message

Frank Lichtenheld May 27, 2023, 9:55 a.m. UTC
Fixes openvpn#344

Change-Id: I7d8a25df8ef62a1e46fdb4a2358972eb4419c564
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
 build/msvc/msvc-generate/Makefile.am | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gert Doering May 27, 2023, 4:37 p.m. UTC | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Thanks.  Trivial, but me and automake...  tested by building a 2.6
tarball, and comparing tarball contents vs. 2.6.4 ("as expected", it
just adds the version.m4.in), and pushing to GHA "just to see that
it won't do something unexpected" (doesn't).

Your patch has been applied to the master and release/2.6 branch.

commit 72d70b5d8a9d6ac01134df006a03607a79e76294 (master)
commit cfcc20ff2bf184edb06e2d918d697f0ef81a0e82 (release/2.6)
Author: Frank Lichtenheld
Date:   Sat May 27 11:55:04 2023 +0200

     msvc-generate: include version.m4.in in tarball

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20230527095504.17915-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26732.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/build/msvc/msvc-generate/Makefile.am b/build/msvc/msvc-generate/Makefile.am
index aa4f0dae..9d04326d 100644
--- a/build/msvc/msvc-generate/Makefile.am
+++ b/build/msvc/msvc-generate/Makefile.am
@@ -15,4 +15,5 @@  MAINTAINERCLEANFILES = \
 dist_noinst_DATA = \
 	msvc-generate.vcxproj \
 	Makefile.mak \
-	msvc-generate.js
+	msvc-generate.js \
+	version.m4.in