diff mbox series

[Openvpn-devel,v1] gerrit-send-mail: Make output consistent across systems

Message ID 20240129145756.769-1-gert@greenie.muc.de
State Accepted
Headers
Series [Openvpn-devel,v1] gerrit-send-mail: Make output consistent across systems |

Commit Message

Gert Doering Jan. 29, 2024, 2:57 p.m. UTC 
  From: Frank Lichtenheld <frank@lichtenheld.com>

When writing the file specify encoding and newline, so that
the local settings (like locale) do not change the output.

Change-Id: Id7b4bda38adfbb446bdac635ac5d5207ef3f2f40
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/508
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>

Comments

Gert Doering Jan. 29, 2024, 3:05 p.m. UTC | #1 
Fixes issues with UTF8 in Files (user_pass UT test).

For added fanciness, could set charset header in resulting mail, so
"git send-email" wouldn't have to ask... but that's less nuisance than
"python explodes because UTF8" :-)

Your patch has been applied to the master branch.

commit e1f8c599aeb840909f5ea8e9ae0bc4dab5bc7deb
Author: Frank Lichtenheld
Date:   Mon Jan 29 15:57:56 2024 +0100

     gerrit-send-mail: Make output consistent across systems

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Message-Id: <20240129145756.769-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28153.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/dev-tools/gerrit-send-mail.py b/dev-tools/gerrit-send-mail.py
index 5429aef..67a2cf1 100755
--- a/dev-tools/gerrit-send-mail.py
+++ b/dev-tools/gerrit-send-mail.py
@@ -109,7 +109,7 @@ 
     )
     filename = f"gerrit-{args.changeid}-{details['revision']}.patch"
     patch_text_final = patch_text_mod.replace("Subject: [PATCH v1]", f"Subject: [PATCH v{details['revision']}]")
-    with open(filename, "w") as patch_file:
+    with open(filename, "w", encoding="utf-8", newline="\n") as patch_file:
         patch_file.write(patch_text_final)
     print("send with:")
     print(f"git send-email --in-reply-to {details['msg_id']} {filename}")