| Message ID | 20250919113207.25440-1-gert@greenie.muc.de |
|---|---|
| State | Accepted |
| Headers |
Return-Path: <openvpn-devel-bounces@lists.sourceforge.net>
Delivered-To: patchwork@openvpn.net
Received: by 2002:a05:7000:6a92:b0:72f:f16c:e055 with SMTP id u18csp104589maw;
Fri, 19 Sep 2025 04:32:19 -0700 (PDT)
X-Forwarded-Encrypted: i=2;
AJvYcCX1npL0sAKFEXQfpbtJx2IGK+0Hi5mqBtyU2h1Uw6LTPY//abgD2Yob2yMHJuq0POYerX8Vk1Mr9LQ=@openvpn.net
X-Google-Smtp-Source:
AGHT+IHSZrF3XYa7FXP/tW5TpULzgLUsvxc65sdBdDygeIsDe2+0P8DgWuoT33cwqakSk6/m0bLw
X-Received: by 2002:a05:6808:219f:b0:438:201f:e036 with SMTP id
5614622812f47-43d6c155c84mr1091219b6e.9.1758281538987;
Fri, 19 Sep 2025 04:32:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1758281538; cv=none;
d=google.com; s=arc-20240605;
b=OHSfF3ahToPfL8hTl2s4A3kuYOXVTk7UCmlF8Ys1UlLWkdGdZrerTPGuHDsYUiPD1G
q5Pa9LayowER53mxc8TKADDtPw3M4WVnaIiUsV9hCxUVYzLmKqBTw988Yk4OX7pvP3Si
V99Y2JZu9SvOqSZcaOlHo+lfSiyVGmkOJ/qlPIbIPu7uKVtMR8qdSNGtqN3UhQ5Z7yLD
9EJaSIdQwOhq+aGAMQK57UGWyeVpKRcZPot1PZxf07Kezpx4gl5fo+rANer6jt8qoeN6
oUx8MNuGzynk4atHZg6+qMczHeu9L85zMG+tJp0YaPmRsQULNUfQuQmt8q/yOmwqxLbq
hRBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20240605;
h=errors-to:content-transfer-encoding:list-subscribe:list-help
:list-post:list-archive:list-unsubscribe:list-id:precedence:subject
:mime-version:references:in-reply-to:message-id:date:to:from
:dkim-signature:dkim-signature:dkim-signature;
bh=QMFq5IYu3zevhrFJRRTAig+6SOu7yIw76URIJRJVlcI=;
fh=4NbAC/LsuMLI0S0hprUlLSLCiHwg6SCAifhH718Jh0Q=;
b=lhWS8asxmT8nJNK5cJSavPJQsYkWjZfBT1G7mf8Iodp2Dj2E3aSaCGGIuD/9I3LBzC
Zw3so8LjOxrTnndT0oaRLZ8FhMQJGoUSHuAA1+xetaXKU96mke7R2ELa74f8sPl5a5Z9
MCs83XzfimFoujzN+1FUvm6gZQfkAEz7TEj7HeU/GjOaEOPbcmODJRRJ2++qQKNdQd+x
nEuGBINGDOxtcjQnJrR0j1cJa6guAKKnUNPAAklqOyqJ67xsMEIFClpTes1aXC7mHzLQ
wv+HJ1IYZAcG+URaifHSRQzLjWYaKl2BLGY341/N+pmXhIg6fMO7H8Dir6jM2LLApRJ9
0x1w==;
dara=google.com
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=Ozs7I33I;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=kLB8FMvz;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=VhXEZTDX;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
Received: from lists.sourceforge.net (lists.sourceforge.net. [216.105.38.7])
by mx.google.com with ESMTPS id
5614622812f47-43d5c85ef47si1139538b6e.301.2025.09.19.04.32.18
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Fri, 19 Sep 2025 04:32:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) client-ip=216.105.38.7;
Authentication-Results: mx.google.com;
dkim=pass header.i=@lists.sourceforge.net header.s=beta
header.b=Ozs7I33I;
dkim=neutral (body hash did not verify) header.i=@sourceforge.net
header.s=x header.b=kLB8FMvz;
dkim=neutral (body hash did not verify) header.i=@sf.net header.s=x
header.b=VhXEZTDX;
spf=pass (google.com: domain of
openvpn-devel-bounces@lists.sourceforge.net designates 216.105.38.7 as
permitted sender) smtp.mailfrom=openvpn-devel-bounces@lists.sourceforge.net;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=muc.de
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:
List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:
Subject:MIME-Version:References:In-Reply-To:Message-ID:Date:To:From:Sender:
Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
bh=QMFq5IYu3zevhrFJRRTAig+6SOu7yIw76URIJRJVlcI=; b=Ozs7I33IWoNRCtjrL5NR4U+DET
4CODE6MhrRAGhkxBj1tA9FOvSALm41434CGEhVZEQM3LYheTj2l/heLcmX0YuywPfUMeOxQC4Dhsq
gFmBUzVhyPAysQb5YgOwAYaH1GrvU615AdjkrqOxw/93BUPGpgllKGdW+fdc4NdzJiU4=;
Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com)
by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95)
(envelope-from <openvpn-devel-bounces@lists.sourceforge.net>)
id 1uzZLc-0001NY-EX;
Fri, 19 Sep 2025 11:32:16 +0000
Received: from [172.30.29.66] (helo=mx.sourceforge.net)
by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95)
(envelope-from <gert@blue4.greenie.muc.de>) id 1uzZLb-0001NS-RJ
for openvpn-devel@lists.sourceforge.net;
Fri, 19 Sep 2025 11:32:15 +0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References:
In-Reply-To:Message-ID:Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:
Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender:
Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:
List-Subscribe:List-Post:List-Owner:List-Archive;
bh=dVgpxahMMj52iBFimP2N+dyp80lCC/WOMY2nFncnDgA=; b=kLB8FMvzdXoTgPtNNdkIaGUd7+
FHeKINZFkvkTJ37g6jzDPpiuyjbYfq/lopvqn1PdY0EOY/9UX7Cdnb3hYI/KKZG7ZPf5oRedNcrv0
bhkcLkdDdPu+vWHsL9wVzTBtKKFz5XcOYAwsZ+MZewVD2y8oalC2WoMzOjEupzFJnThU=;
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x
;
h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:
Date:Subject:To:From:Sender:Reply-To:Cc:Content-Type:Content-ID:
Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
List-Post:List-Owner:List-Archive;
bh=dVgpxahMMj52iBFimP2N+dyp80lCC/WOMY2nFncnDgA=; b=VhXEZTDXpp472nWn5t7ZayzWrL
uDGDoRTy9PXPjvE6xzx8Ov1rzkhon5a9U5YZ8DRpcuhAEe6nb6DkHGAVzgOlqoG4foeChoVysQY3g
rozSzwDUu1Y3tsh/D5LQCuJNM3w6deutiiY/KMzr1XGF0LX2xftVLLhD27HODFxhazx8=;
Received: from [193.149.48.134] (helo=blue.greenie.muc.de)
by sfi-mx-2.v28.lw.sourceforge.com with esmtps
(TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95)
id 1uzZLa-0002FS-S5 for openvpn-devel@lists.sourceforge.net;
Fri, 19 Sep 2025 11:32:15 +0000
Received: from blue.greenie.muc.de (localhost [127.0.0.1])
by blue.greenie.muc.de (8.18.1/8.18.1) with ESMTP id 58JBW8Rv025463
for <openvpn-devel@lists.sourceforge.net>; Fri, 19 Sep 2025 13:32:08 +0200
Received: (from gert@localhost)
by blue.greenie.muc.de (8.18.1/8.18.1/Submit) id 58JBW8NY025462
for openvpn-devel@lists.sourceforge.net; Fri, 19 Sep 2025 13:32:08 +0200
From: Gert Doering <gert@greenie.muc.de>
To: openvpn-devel@lists.sourceforge.net
Date: Fri, 19 Sep 2025 13:31:58 +0200
Message-ID: <20250919113207.25440-1-gert@greenie.muc.de>
X-Mailer: git-send-email 2.49.1
In-Reply-To:
<gerrit.1758280732000.I93406dd91694974df4ea087b9312ae2fafbc7fe7@gerrit.openvpn.net>
References:
<gerrit.1758280732000.I93406dd91694974df4ea087b9312ae2fafbc7fe7@gerrit.openvpn.net>
MIME-Version: 1.0
X-Spam-Score: 1.3 (+)
X-Spam-Report: Spam detection software,
running on the system "sfi-spamd-2.hosts.colo.sdot.me",
has NOT identified this incoming email as spam. The original
message has been attached to this so you can view it or label
similar future email. If you have any questions, see
the administrator of that system for details.
Content preview: From: Lev Stipakov <lev@openvpn.net> Commit 6c3afe5
("Validate DNS domain name before powershell invocation")
Content analysis details: (1.3 points, 5.0 required)
pts rule name description
---- ----------------------
--------------------------------------------------
1.3 RDNS_NONE Delivered to internal network by a host with no rDNS
X-Headers-End: 1uzZLa-0002FS-S5
Subject: [Openvpn-devel] [PATCH v2] Makefile: fix "make dist"
X-BeenThere: openvpn-devel@lists.sourceforge.net
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: <openvpn-devel.lists.sourceforge.net>
List-Unsubscribe: <https://lists.sourceforge.net/lists/options/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive:
<http://sourceforge.net/mailarchive/forum.php?forum_name=openvpn-devel>
List-Post: <mailto:openvpn-devel@lists.sourceforge.net>
List-Help: <mailto:openvpn-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/openvpn-devel>,
<mailto:openvpn-devel-request@lists.sourceforge.net?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: openvpn-devel-bounces@lists.sourceforge.net
X-getmail-retrieved-from-mailbox: Inbox
X-GMAIL-THRID: =?utf-8?q?1843691822643713056?=
X-GMAIL-MSGID: =?utf-8?q?1843691822643713056?=
|
| Series |
[Openvpn-devel,v2] Makefile: fix "make dist"
|
|
Commit Message
Gert Doering
Sept. 19, 2025, 11:31 a.m. UTC
From: Lev Stipakov <lev@openvpn.net> Commit 6c3afe5 ("Validate DNS domain name before powershell invocation") has introduced a new header file but didn't add it to Makefile's SOURCES, breaking "make dist". Change-Id: I93406dd91694974df4ea087b9312ae2fafbc7fe7 Signed-off-by: Lev Stipakov <lev@openvpn.net> Acked-by: Gert Doering <gert@greenie.muc.de> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1201 --- This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to release/2.6. Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1201 This mail reflects revision 2 of this Change. Acked-by according to Gerrit (reflected above): Gert Doering <gert@greenie.muc.de>
Comments
Yeah, silly oversight on my side - I really should remember "if there is a
new file, make sure to run 'make distcheck'"...
So, applied, tested on gentoo with "make distcheck" and it works.
Your patch has been applied to the release/2.6 branch.
commit 7f6d228f8d9426358e359f8c3278250414fd6618 (release/2.6)
Author: Lev Stipakov
Date: Fri Sep 19 13:31:58 2025 +0200
Makefile: fix 'make dist'
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1201
Message-Id: <20250919113207.25440-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33085.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/src/openvpn/Makefile.am b/src/openvpn/Makefile.am index 4492c15..e80179c 100644 --- a/src/openvpn/Makefile.am +++ b/src/openvpn/Makefile.am @@ -57,6 +57,7 @@ dco_win.c dco_win.h \ dhcp.c dhcp.h \ dns.c dns.h \ + domain_helper.h \ env_set.c env_set.h \ errlevel.h \ error.c error.h \