diff mbox series

[Openvpn-devel,v9] ssl: Fix -Wconversion warnings in pem_password_callback

Message ID 20250922204158.23319-1-gert@greenie.muc.de
State Accepted
Headers
Series [Openvpn-devel,v9] ssl: Fix -Wconversion warnings in pem_password_callback |

Commit Message

Gert Doering Sept. 22, 2025, 8:41 p.m. UTC 
  From: Frank Lichtenheld <frank@lichtenheld.com>

The OpenSSL API is how it is, so adapt with casts.

Change-Id: I053ddbb71cc5b9ae16c5a49be833035d943d7eba
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137
This mail reflects revision 9 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering Sept. 23, 2025, 9:15 a.m. UTC | #1 
Straightforward & does not break anything :-) (tested in a local build
with a profile with an encrypted private key)

Your patch has been applied to the master branch.

commit e256d668d6356cdb379bf7ceca1617ed7925d28e
Author: Frank Lichtenheld
Date:   Mon Sep 22 22:41:52 2025 +0200

     ssl: Fix -Wconversion warnings in pem_password_callback

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1137
     Message-Id: <20250922204158.23319-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33154.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/ssl.c b/src/openvpn/ssl.c
index c17e608..284d951 100644
--- a/src/openvpn/ssl.c
+++ b/src/openvpn/ssl.c
@@ -264,10 +264,10 @@ 
         /* prompt for password even if --askpass wasn't specified */
         pem_password_setup(NULL);
         ASSERT(!passbuf.protected);
-        strncpynt(buf, passbuf.password, size);
+        strncpynt(buf, passbuf.password, (size_t)size);
         purge_user_pass(&passbuf, false);
 
-        return strlen(buf);
+        return (int)strlen(buf);
     }
     return 0;
 }