diff mbox series

[Openvpn-devel,v1] remove redundant PULL_DEFINED() macro definition

Message ID 20251028203219.11737-1-gert@greenie.muc.de
State Accepted
Headers
Series [Openvpn-devel,v1] remove redundant PULL_DEFINED() macro definition |

Commit Message

Gert Doering Oct. 28, 2025, 8:32 p.m. UTC 
  this seems to be a leftover of the time when we had conditional
compilation for "--disable-server" or thus.  Commit d6a0cf599
removed PUSH_DEFINED() nearby but overlooked this one.

Change-Id: I9118333bb65cd5db0836abefa5d45a729f0142cc
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Comments

Gert Doering Oct. 29, 2025, 7:08 a.m. UTC | #1 
Trivial enough .-) and BB confirms that I have not overlooked some random
combination of platform and compile time directive.

Patch has been applied to the master branch.

commit e6ae2bc64239dd99a2d2a94e75fdaff45eb78deb
Author: Gert Doering
Date:   Tue Oct 28 21:32:10 2025 +0100

     remove redundant PULL_DEFINED() macro definition

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1322
     Message-Id: <20251028203219.11737-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg33984.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/openvpn/options.h b/src/openvpn/options.h
index 24253af..125e524 100644
--- a/src/openvpn/options.h
+++ b/src/openvpn/options.h
@@ -769,10 +769,6 @@ 
 
 #define PULL_DEFINED(opt) ((opt)->pull)
 
-#ifndef PULL_DEFINED
-#define PULL_DEFINED(opt) (false)
-#endif
-
 #ifdef _WIN32
 #define ROUTE_OPTION_FLAGS(o) ((o)->route_method & ROUTE_METHOD_MASK)
 #else