diff mbox series

[Openvpn-devel,v2] configure.ac: adjust to native inotify support for FreeBSD 15+

Message ID 20260220102106.32024-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v2] configure.ac: adjust to native inotify support for FreeBSD 15+ | expand

Commit Message

Gert Doering Feb. 20, 2026, 10:20 a.m. UTC 
FreeBSD 15 has native inotify support, and no "libinotify.pc" pkg config
file anymore, plus no extra includes are needed.  This works fine if we
conditionalize the FreeBSD check to "freebsd-1[0-4]".

Due to m4 involvement double braces are needed for quoting.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=293176

Reported-by: Ivo Karabojkov <karabojkov@kit.bg>
Reported-by: Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>

Change-Id: Ie3f209a641c2f56494dfc7720b13f2a2ba3001a8
Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Antonio Quartulli <antonio@mandelbit.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1535
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1535
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Antonio Quartulli <antonio@mandelbit.com>

Comments

Gert Doering Feb. 20, 2026, 2:24 p.m. UTC | #1 
Tested on FreeBSD 14 ("needs libinotify pkg") and 15 ("built-in, no 
pkg, no CFLAGS etc. needed").

Patch has been applied to the master, release/2.7 and release/2.6 branch
(long-term compat).

commit 38243844f225517fa1d288517db9a34a33c5ad13 (master)
commit d9279c77f796a45cd94e929376d5d4d9cbae34eb (release/2.7)
commit a4bf28df70385b71934ab0016560eadf4c4ea542 (release/2.6)
Author: Gert Doering
Date:   Fri Feb 20 11:20:58 2026 +0100

     configure.ac: adjust to native inotify support for FreeBSD 15+

     Signed-off-by: Gert Doering <gert@greenie.muc.de>
     Acked-by: Antonio Quartulli <antonio@mandelbit.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1535
     Message-Id: <20260220102106.32024-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35761.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 9fa6a41..e151816 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1294,7 +1294,7 @@ 
 
 if test "${enable_async_push}" = "yes"; then
 	case "$host" in
-		*-*-freebsd*)
+		*-*-freebsd1[[0-4]]*)
 			PKG_CHECK_MODULES(
 				[OPTIONAL_INOTIFY],
 				[libinotify],