diff mbox series

[Openvpn-devel,v1] t_client.sh: Do not use CA_CERT variable as indicator for good .rc file

Message ID 20260506145933.22301-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v1] t_client.sh: Do not use CA_CERT variable as indicator for good .rc file | expand

Commit Message

Gert Doering May 6, 2026, 2:59 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

t_client.sh doesn't actually care about this variable, and our
.rc files do not use it anymore. If you really want to dynamically
skip running t_client.sh just set TEST_RUN_LIST to empty in the .rc
file.

Change-Id: I7cf7146c3c4f1a01b0bcb57e03d09b32f8b59780
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1664
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1664
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering May 6, 2026, 5:02 p.m. UTC | #1 
I agree that this check has outlived its usefulness - "back then", the
assumption was "you always need a CA and Key and Cert", but with inline
configs & --fingerprint and all this, this no longer holds true.

I don't think there is a pressing need to backport this to the other
branches we regularily test (2.6, 2.7) as "as of now" our CI setups have
already been workarounded ("CA_CERT=1").

Your patch has been applied to the master branch.

commit 841ab0b216a424eb0100448362f76a2c12b3a516
Author: Frank Lichtenheld
Date:   Wed May 6 16:59:28 2026 +0200

     t_client.sh: Do not use CA_CERT variable as indicator for good .rc file

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1664
     Message-Id: <20260506145933.22301-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36827.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/tests/t_client.sh.in b/tests/t_client.sh.in
index a49de40..48e2446 100755
--- a/tests/t_client.sh.in
+++ b/tests/t_client.sh.in
@@ -62,11 +62,6 @@ 
     exit 1
 fi
 
-if [ -z "$CA_CERT" ] ; then
-    echo "CA_CERT not defined in 't_client.rc'. SKIP test." >&2
-    exit "${TCLIENT_SKIP_RC}"
-fi
-
 if [ -z "$TEST_RUN_LIST" ] ; then
     echo "TEST_RUN_LIST empty, no tests defined.  SKIP test." >&2
     exit "${TCLIENT_SKIP_RC}"