[Openvpn-devel] configure: remove useless -Wno-* from default CFLAGS

Message ID 20211005122736.4060-1-a@unstable.cc
State Accepted
Headers show
Series
  • [Openvpn-devel] configure: remove useless -Wno-* from default CFLAGS
Related show

Commit Message

Antonio Quartulli Oct. 5, 2021, 12:27 p.m.
Historically we always had -Wno-unused-parameter and
-Wno-unused-function enabled along with -Wall.

When we made -Wall a default option, we carried the other two along and
made them default too (in 2018).

Now the code is much cleaner compared to the past and we do not really
require -Wno-unused-parameter and -Wno-unused-function anymore.

Actually they may hide really unused functions that we'd need to
cleanup.

For this reason remove -Wno-unused-parameter and -Wno-unused-function
for good from the default CFLAGS.

Any new warning should rather be fixed than hidden.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
 configure.ac | 2 --
 1 file changed, 2 deletions(-)

Comments

Gert Doering Oct. 6, 2021, 10 a.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"Because it makes sense"

Your patch has been applied to the master and release/2.5 branch
(this will not directly effect actual code generation, but if we can see 
and fix a warning in 2.5 that way, all the better).

commit 01ce6ca39d1f4bf45dcd49baede0094c4c990d3b (master)
commit 64c96c003264fd69327bb54f7c28bb41b13d0ab7 (release/2.5)
Author: Antonio Quartulli
Date:   Tue Oct 5 14:27:36 2021 +0200

     configure: remove useless -Wno-* from default CFLAGS

     Signed-off-by: Antonio Quartulli <a@unstable.cc>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <20211005122736.4060-1-a@unstable.cc>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22917.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering

Patch

diff --git a/configure.ac b/configure.ac
index 7c2ead6a..a37dc762 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1224,8 +1224,6 @@  AC_DEFUN([ACL_CHECK_ADD_COMPILE_FLAGS], [
 )
 
 ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-stringop-truncation])
-ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-function])
-ACL_CHECK_ADD_COMPILE_FLAGS([-Wno-unused-parameter])
 ACL_CHECK_ADD_COMPILE_FLAGS([-Wall])
 
 if test "${enable_pedantic}" = "yes"; then