[Openvpn-devel] Make build deterministic, remove __DATE__

Message ID 20211213162841.15763-1-frank@lichtenheld.com
State New
Headers show
Series
  • [Openvpn-devel] Make build deterministic, remove __DATE__
Related show

Commit Message

Frank Lichtenheld Dec. 13, 2021, 4:28 p.m.
The information provided by this is minimal
and it makes it more difficult to provide
deterministic builds. There are work-arounds
for that but I think it is easier to just remove
it completely.

Allows the build to pass with -Wdate-time -Werror.

Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
 src/openvpn/options.c | 1 -
 src/tapctl/main.c     | 1 -
 2 files changed, 2 deletions(-)

Comments

Arne Schwabe Dec. 13, 2021, 5:47 p.m. | #1
Am 13.12.21 um 17:28 schrieb Frank Lichtenheld:
> The information provided by this is minimal
> and it makes it more difficult to provide
> deterministic builds. There are work-arounds
> for that but I think it is easier to just remove
> it completely.
> 
Acked-By: Arne Schwabe <arne@rfc2549.org>
Antonio Quartulli Jan. 21, 2022, 9:55 p.m. | #2
Hi,

On 13/12/2021 17:28, Frank Lichtenheld wrote:
> The information provided by this is minimal
> and it makes it more difficult to provide
> deterministic builds. There are work-arounds
> for that but I think it is easier to just remove
> it completely.
> 
> Allows the build to pass with -Wdate-time -Werror.
> 
> Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>

Acked-by: Antonio Quartulli <a@unstable.cc>

Patch

diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index ac13412a..79f453d4 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -105,7 +105,6 @@  const char title_string[] =
 #endif
 #endif
     " [AEAD]"
-    " built on " __DATE__
 ;
 
 #ifndef ENABLE_SMALL
diff --git a/src/tapctl/main.c b/src/tapctl/main.c
index a3d3966a..d60df275 100644
--- a/src/tapctl/main.c
+++ b/src/tapctl/main.c
@@ -44,7 +44,6 @@ 
 
 const TCHAR title_string[] =
     TEXT(PACKAGE_NAME) TEXT(" ") TEXT(PACKAGE_VERSION)
-    TEXT(" built on ") TEXT(__DATE__)
 ;
 
 static const TCHAR usage_message[] =