[Openvpn-devel,2/3] Make second parameter to reliable_send_purge() const

Message ID 1531924073-29243-3-git-send-email-steffan.karger@fox-it.com
State Accepted
Headers show
Series
  • [Openvpn-devel,1/3] Minor reliability layer documentation fixes
Related show

Commit Message

Steffan Karger July 18, 2018, 2:27 p.m.
From: Gert van Dijk <gert.vandijk@fox-it.com>

Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
---
 src/openvpn/reliable.c | 2 +-
 src/openvpn/reliable.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Gert Doering July 18, 2018, 5:49 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

Code doesn't modify *ack, so we can as well tell the compiler about it :)

Your patch has been applied to the master branch (this is not a bugfix
and not a long-term stability thing or documentation update, so it does 
not need to go to 2.4)

commit 0f83b5e33ed63fee9f8de384e46cf93b4687c508 (master)
Author: Gert van Dijk
Date:   Wed Jul 18 16:27:52 2018 +0200

     Make second parameter to reliable_send_purge() const

     Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <1531924073-29243-3-git-send-email-steffan.karger@fox-it.com>
     URL: https://www.mail-archive.com/search?l=mid&q=1531924073-29243-3-git-send-email-steffan.karger@fox-it.com
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c
index b62ab54..d295076 100644
--- a/src/openvpn/reliable.c
+++ b/src/openvpn/reliable.c
@@ -352,7 +352,7 @@  reliable_empty(const struct reliable *rel)
 
 /* del acknowledged items from send buf */
 void
-reliable_send_purge(struct reliable *rel, struct reliable_ack *ack)
+reliable_send_purge(struct reliable *rel, const struct reliable_ack *ack)
 {
     int i, j;
     for (i = 0; i < ack->len; ++i)
diff --git a/src/openvpn/reliable.h b/src/openvpn/reliable.h
index 4d8fc37..688c65c 100644
--- a/src/openvpn/reliable.h
+++ b/src/openvpn/reliable.h
@@ -123,7 +123,7 @@  bool reliable_ack_read(struct reliable_ack *ack,
  * @param ack The acknowledgment structure containing received
  *     acknowledgments.
  */
-void reliable_send_purge(struct reliable *rel, struct reliable_ack *ack);
+void reliable_send_purge(struct reliable *rel, const struct reliable_ack *ack);
 
 /** @} name Functions for processing incoming acknowledgments */