[Openvpn-devel,3/3] Remove unneeded newline in debug message in reliable.c

Message ID 1531924073-29243-4-git-send-email-steffan.karger@fox-it.com
State Accepted
Headers show
Series
  • [Openvpn-devel,1/3] Minor reliability layer documentation fixes
Related show

Commit Message

Steffan Karger July 18, 2018, 2:27 p.m.
From: Gert van Dijk <gert.vandijk@fox-it.com>

Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
---
 src/openvpn/reliable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gert Doering July 18, 2018, 5:51 p.m. | #1
Acked-by: Gert Doering <gert@greenie.muc.de>

"obvious fix", but if you're used to debugging with printf(), these
newlines slip in... :-) - thanks for fixing.

Your patch has been applied to the master branch.

commit 3e5561d34099f28a759865efff0523005116b6a1
Author: Gert van Dijk
Date:   Wed Jul 18 16:27:53 2018 +0200

     Remove unneeded newline in debug message in reliable.c

     Signed-off-by: Steffan Karger <steffan.karger@fox-it.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Message-Id: <1531924073-29243-4-git-send-email-steffan.karger@fox-it.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg17262.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Patch

diff --git a/src/openvpn/reliable.c b/src/openvpn/reliable.c
index d295076..a7f4ed9 100644
--- a/src/openvpn/reliable.c
+++ b/src/openvpn/reliable.c
@@ -462,7 +462,7 @@  reliable_wont_break_sequentiality(const struct reliable *rel, packet_id_type id)
              (packet_id_print_type)id, reliable_print_ids(rel, &gc));
     }
 
-    dmsg(D_REL_DEBUG, "ACK RWBS rel->size=%d rel->packet_id=%08x id=%08x ret=%d\n", rel->size, rel->packet_id, id, ret);
+    dmsg(D_REL_DEBUG, "ACK RWBS rel->size=%d rel->packet_id=%08x id=%08x ret=%d", rel->size, rel->packet_id, id, ret);
 
     gc_free(&gc);
     return ret;