[Openvpn-devel] Wrong FILETYPE in .rc files

Message ID aa4f4026-a684-f96d-c8cb-d4f8a3468c4c@gmail.com
State New
Headers show
Series
  • [Openvpn-devel] Wrong FILETYPE in .rc files
Related show

Commit Message

Gisle Vanem July 3, 2019, 1:45 p.m.
I noticed the .rc-files for programs uses
'FILETYPE 0x2L'. The 0x2L' is for a .DLL (VFT_DLL).

Ref: Win-Kit's 'um/verrsrc.h':
   #define VFT_DLL 0x00000002L

Hence these '0x2L' should be replaced with 'VFT_APP':

Patch

--- a/src/openvpn/openvpn_win32_resources.rc 2016-11-06 10:54:00
+++ b/src/openvpn/openvpn_win32_resources.rc 2019-07-03 11:54:06
@@ -19,7 +19,7 @@ 
   FILEFLAGS 0x0L
  #endif
   FILEOS 0x40004L
- FILETYPE 0x2L
+ FILETYPE VFT_APP
   FILESUBTYPE 0x0L
  BEGIN
      BLOCK "StringFileInfo"

--- a/src/openvpnserv/openvpnserv_resources.rc 2016-11-06 10:54:01
+++ b/src/openvpnserv/openvpnserv_resources.rc 2019-07-03 11:54:25
@@ -19,7 +19,7 @@ 
   FILEFLAGS 0x0L
  #endif
   FILEOS 0x40004L
- FILETYPE 0x2L
+ FILETYPE VFT_APP
   FILESUBTYPE 0x0L
  BEGIN
      BLOCK "StringFileInfo"