[Openvpn-devel,S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

Message ID 0768d158f9982da5613e353a86618e05d8cf656c-HTML@gerrit.openvpn.net
State Superseded
Headers show
Series [Openvpn-devel,S] Change in openvpn[master]: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway | expand

Commit Message

its_Giaan (Code Review) Nov. 30, 2023, 4:24 p.m. UTC
Attention is currently required from: flichtenheld.

Hello flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/463?usp=email

to review the following change.


Change subject: Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway
......................................................................

Remove TEST_GET_DEFAULT_GATEWAY as it duplicates --show-gateway

This debug code is not very useful as it is outdated and the same
functionality is provided by --show-gateway

Change-Id: Ie7fd59cc84e2eb024086c28c2ec2a5606a2b2e7c
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
M src/openvpn/init.c
1 file changed, 0 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/63/463/1

Patch

diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index abba748..fdab26b 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -885,17 +885,6 @@ 
     return false;
 #endif
 
-#ifdef TEST_GET_DEFAULT_GATEWAY
-    {
-        struct route_gateway_info rgi;
-        struct route_ipv6_gateway_info rgi6;
-        get_default_gateway(&rgi);
-        get_default_gateway_ipv6(&rgi6, NULL);
-        print_default_gateway(M_INFO, &rgi, &rgi6);
-        return false;
-    }
-#endif
-
 #ifdef GEN_PATH_TEST
     {
         struct gc_arena gc = gc_new();