| Message ID | 20220812130657.29899-9-a@unstable.cc |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ovpn-dco: leftovers | expand |
Acked-by: Gert Doering <gert@greenie.muc.de> As we discussed :-) - trivial enough. Without that patch: $ openvpn --verb 3 ... 2022-08-13 20:51:06 Cannot find ovpn_dco netlink component: Object not found 2022-08-13 20:51:06 Note: Kernel support for ovpn-dco missing, disabling data channel offload. 2022-08-13 20:51:06 OpenVPN 2.6_git [git:master/d7f16eea8e939b42] x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] [DCO] built on Aug 13 2022 with that patch: 2022-08-13 20:52:12 Note: Kernel support for ovpn-dco missing, disabling data channel offload. 2022-08-13 20:52:12 OpenVPN 2.6_git [git:master/29f20e738531f0e6] x86_64-pc-linux-gnu [SSL (OpenSSL)] [LZO] [LZ4] [EPOLL] [MH/PKTINFO] [AEAD] [DCO] built on Aug 13 2022 and with --verb 7 it shows up again. The way we currently print some informational messages before and others after the version number is highly improvable, and I've opened a Trac ticket for it... (#1470) Your patch has been applied to the master branch. commit 29f20e738531f0e65df1bc330f598b3d1eb60b22 Author: Antonio Quartulli Date: Fri Aug 12 15:06:55 2022 +0200 ovpn-dco: print some netlink messages to debug level Signed-off-by: Antonio Quartulli <a@unstable.cc> Acked-by: Gert Doering <gert@greenie.muc.de> Message-Id: <20220812130657.29899-9-a@unstable.cc> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24892.html Signed-off-by: Gert Doering <gert@greenie.muc.de> -- kind regards, Gert Doering
diff --git a/src/openvpn/dco_linux.c b/src/openvpn/dco_linux.c index f86ea819..9212339e 100644 --- a/src/openvpn/dco_linux.c +++ b/src/openvpn/dco_linux.c @@ -913,7 +913,7 @@ nla_put_failure: bool dco_available(int msglevel) { - if (resolve_ovpn_netlink_id(msglevel) < 0) + if (resolve_ovpn_netlink_id(D_DCO_DEBUG) < 0) { msg(msglevel, "Note: Kernel support for ovpn-dco missing, disabling data channel offload.");
Netlink errors detected during dco availability detection are not really required and can confuse the user. Have them printed to the dco debug level. Signed-off-by: Antonio Quartulli <a@unstable.cc> --- src/openvpn/dco_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)