diff mbox series

[Openvpn-devel,3/5] Update LibreSSL to 3.7.0 in Github actions

Message ID 20230130172936.3444840-3-arne@rfc2549.org
State Accepted
Headers
Series [Openvpn-devel,1/5] Fix unaligned access in auth-token |

Commit Message

Arne Schwabe Jan. 30, 2023, 5:29 p.m. UTC 
  The version 3.5.3 triggers undefined behaviour with the usan sanatizer.
Updating LibreSSSL to 3.7.0 does unfortunately does not fix the issue but
at least we are now using a current version.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
---
 .github/workflows/build.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Frank Lichtenheld Jan. 31, 2023, 10:55 a.m. UTC | #1 
On Mon, Jan 30, 2023 at 06:29:34PM +0100, Arne Schwabe wrote:
> The version 3.5.3 triggers undefined behaviour with the usan sanatizer.
> Updating LibreSSSL to 3.7.0 does unfortunately does not fix the issue but
> at least we are now using a current version.
> 
> Signed-off-by: Arne Schwabe <arne@rfc2549.org>
> ---
>  .github/workflows/build.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
> index 2db90bcde..6adb69563 100644
> --- a/.github/workflows/build.yaml
> +++ b/.github/workflows/build.yaml
> @@ -409,7 +409,7 @@ jobs:
>          with:
>            path: libressl
>            repository: libressl-portable/portable
> -          ref: v3.5.3
> +          ref: v3.7.0
>        - name: "libressl: autogen.sh"
>          run: ./autogen.sh
>          working-directory: libressl
> @@ -417,7 +417,7 @@ jobs:
>          run: autoreconf -fvi
>          working-directory: libressl
>        - name: "libressl: configure"
> -        run: ./configure --enable-openvpn
> +        run: ./configure
>          working-directory: libressl
>        - name: "libressl: make all"

Acked-By: Frank Lichtenheld <frank@lichtenheld.com>

Always good to update to latest.

Regards,
Gert Doering Feb. 1, 2023, 4:25 p.m. UTC | #2 
Your patch has been applied to the master and release/2.6 branch.

commit dc8f1f3963af8bce5e03c333dce9a0b252f6e1fd (master)
commit 3973845ea5bc3fdc15a158917d819b5e9bd92635 (release/2.6)
Author: Arne Schwabe
Date:   Mon Jan 30 18:29:34 2023 +0100

     Update LibreSSL to 3.7.0 in Github actions

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20230130172936.3444840-3-arne@rfc2549.org>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26105.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index 2db90bcde..6adb69563 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -409,7 +409,7 @@  jobs:
         with:
           path: libressl
           repository: libressl-portable/portable
-          ref: v3.5.3
+          ref: v3.7.0
       - name: "libressl: autogen.sh"
         run: ./autogen.sh
         working-directory: libressl
@@ -417,7 +417,7 @@  jobs:
         run: autoreconf -fvi
         working-directory: libressl
       - name: "libressl: configure"
-        run: ./configure --enable-openvpn
+        run: ./configure
         working-directory: libressl
       - name: "libressl: make all"
         run: make -j3