| Message ID | 20230706171922.752429-1-heiko@ist.eigentlich.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [Openvpn-devel] work around false positive warning with mingw 12 | expand |
Am 06.07.23 um 19:19 schrieb Heiko Hund: > When cross compiling for Windows with Ubuntu 23.04 mingw complains about > > route.c:344:26: warning: ‘special.S_un.S_addr’ may be used uninitialized > > which is wrong technically. However the workaround isn't really > intrusive and while there are other warnings caused by libtool, the > cmake mingw build completes with -Werror now. > > Change-Id: I8a0f59707570722eab41af2db76980ced04e6d54 > Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> > --- > src/openvpn/route.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/openvpn/route.c b/src/openvpn/route.c > index 0d04a5a3..0b369da4 100644 > --- a/src/openvpn/route.c > +++ b/src/openvpn/route.c > @@ -319,7 +319,7 @@ init_route(struct route_ipv4 *r, > const in_addr_t default_netmask = IPV4_NETMASK_HOST; > bool status; > int ret; > - struct in_addr special; > + struct in_addr special = {0}; > > CLEAR(*r); > r->option = ro; Good enough. Acked-By: Arne Schwabe <arne@rfc2549.org>
Test compiled on Linux and FreeBSD, just to get two more compiler's
opinions...
Your patch has been applied to the master and release/2.6 branch.
commit d559affd313a8f995db15908887fbc8f16a24659 (master)
commit cbf295ab42affcbdc09261cf3a39eb1d3d9f9cb2 (release/2.6)
Author: Heiko Hund
Date: Thu Jul 6 19:19:22 2023 +0200
work around false positive warning with mingw 12
Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20230706171922.752429-1-heiko@ist.eigentlich.net>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26831.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
--
kind regards,
Gert Doering
diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 0d04a5a3..0b369da4 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -319,7 +319,7 @@ init_route(struct route_ipv4 *r, const in_addr_t default_netmask = IPV4_NETMASK_HOST; bool status; int ret; - struct in_addr special; + struct in_addr special = {0}; CLEAR(*r); r->option = ro;
When cross compiling for Windows with Ubuntu 23.04 mingw complains about route.c:344:26: warning: ‘special.S_un.S_addr’ may be used uninitialized which is wrong technically. However the workaround isn't really intrusive and while there are other warnings caused by libtool, the cmake mingw build completes with -Werror now. Change-Id: I8a0f59707570722eab41af2db76980ced04e6d54 Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net> --- src/openvpn/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)