[Openvpn-devel,v1] Remove dead remains of extract_x509_field_test

Message ID 20231201111846.15097-1-frank@lichtenheld.com
State Accepted
Headers show
Series [Openvpn-devel,v1] Remove dead remains of extract_x509_field_test | expand

Commit Message

Frank Lichtenheld Dec. 1, 2023, 11:18 a.m. UTC
From: Arne Schwabe <arne@rfc2549.org>

This removes some leftover references to extract_x509_field_test that
was removed 15 years ago in commit 564cbab5f.

Change-Id: Ie511a586cf022afcab9d67891ff80676ac7d47b9
Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/462
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>

Small fix in commit message added manually.


Gert Doering Dec. 2, 2023, 3:23 p.m. UTC | #1
Obviously so :-) - haven't tested anything, as all removed code is
insides #ifdef that are never defined (and the function body itself 
is long gone).

Your patch has been applied to the master branch.

commit 5ce74caa39cf6335bb4b5b394e1ac4da3c9b9a3f
Author: Arne Schwabe
Date:   Fri Dec 1 12:18:46 2023 +0100

     Remove dead remains of extract_x509_field_test

     Signed-off-by: Arne Schwabe <arne@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Message-Id: <20231201111846.15097-1-frank@lichtenheld.com>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg27625.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>

kind regards,

Gert Doering


diff --git a/src/openvpn/init.c b/src/openvpn/init.c
index 8c707a4..abba748 100644
--- a/src/openvpn/init.c
+++ b/src/openvpn/init.c
@@ -880,11 +880,6 @@ 
     return false;
-    extract_x509_field_test();
-    return false;
 #ifdef TIME_TEST
     return false;
diff --git a/src/openvpn/ssl.h b/src/openvpn/ssl.h
index e842746..6ba6ff8 100644
--- a/src/openvpn/ssl.h
+++ b/src/openvpn/ssl.h
@@ -540,9 +540,6 @@ 
-/*#define EXTRACT_X509_FIELD_TEST*/
-void extract_x509_field_test(void);
  * Given a key_method, return true if opcode represents the one of the
  * hard_reset op codes for key-method 2