[Openvpn-devel,v1] event: Remove unused function event_set_return_init

Message ID 20260824161558.1869-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] event: Remove unused function event_set_return_init |

Commit Message

Gert Doering Aug. 24, 2026, 4:15 p.m. UTC
  From: Frank Lichtenheld <frank@lichtenheld.com>

This has never been used in the git history.
It is also equivalent to just using CLEAR().

Identified by cppcheck.

Change-Id: I2cf5da2aa6fbb68116c7b6ef587a6494acae0b54
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1867
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1867
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>
  

Comments

Gert Doering Aug. 25, 2026, 7:37 a.m. UTC | #1
And another easy one... :-)

Your patch has been applied to the master branch.

commit 3da1b9ba93f568d4ca498cc3ab9febe55d679fd3
Author: Frank Lichtenheld
Date:   Mon Aug 24 18:15:52 2026 +0200

     event: Remove unused function event_set_return_init

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1867
     Message-Id: <20260824161558.1869-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg38641.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
  

Patch

diff --git a/src/openvpn/event.h b/src/openvpn/event.h
index 40ed161..b784dfe 100644
--- a/src/openvpn/event.h
+++ b/src/openvpn/event.h
@@ -190,13 +190,6 @@ 
     return ret;
 }
 
-static inline void
-event_set_return_init(struct event_set_return *esr)
-{
-    esr->rwflags = 0;
-    esr->arg = NULL;
-}
-
 #ifdef _WIN32
 
 static inline void