diff mbox series

[Openvpn-devel,v1] manage: drop unused input parameter of management_query_multiline()

Message ID 20261104124859.18417-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] manage: drop unused input parameter of management_query_multiline() |

Commit Message

Gert Doering Nov. 4, 2026, 12:48 p.m. UTC 
  From: Razvan Cojocaru <razvanc@mailbox.org>

The parameter has never been used since the function was added in
39e3d336 ("Mac OS X Keychain management client"). Its callers read the
input list themselves.

Change-Id: I40059eb9af845a5070ebb8caff741b0794632de2
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2125
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2125
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
diff mbox series

Patch

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 58f63e6..57a9561 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -3830,7 +3830,7 @@ 
 
 static int
 management_query_multiline(struct management *man, const char *b64_data, const char *prompt,
-                           const char *cmd, int *state, struct buffer_list **input)
+                           const char *cmd, int *state)
 {
     struct gc_arena gc = gc_new();
     int ret = 0;
@@ -3914,7 +3914,7 @@ 
     int ok;
     char *result = NULL;
 
-    ok = management_query_multiline(man, b64_data, prompt, cmd, state, input);
+    ok = management_query_multiline(man, b64_data, prompt, cmd, state);
     if (ok && buffer_list_defined(*input))
     {
         buffer_list_aggregate_separator(*input, 10000, "\n");
@@ -3941,7 +3941,7 @@ 
 {
     char *result = NULL;
 
-    const int ok = management_query_multiline(man, b64_data, prompt, cmd, state, input);
+    const int ok = management_query_multiline(man, b64_data, prompt, cmd, state);
     if (ok && buffer_list_defined(*input))
     {
         buffer_list_aggregate(*input, 2048);