diff mbox series

[Openvpn-devel,v1] tun: log the actual error in Windows tun_read_queue()

Message ID 20261104124931.18525-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v1] tun: log the actual error in Windows tun_read_queue() |

Commit Message

Gert Doering Nov. 4, 2026, 12:49 p.m. UTC 
  From: Razvan Cojocaru <razvanc@mailbox.org>

The read error message passed the ReadFile() result, which is always
FALSE on that path, to strerror_win32() instead of GetLastError()'s
err, so it never showed the real error.

Change-Id: I8b9efc75656e01df9afe99c280ba8c9c82e937f0
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2120
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2120
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Frank Lichtenheld <frank@lichtenheld.com>
diff mbox series

Patch

diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c
index 225d8b1..10f738c 100644
--- a/src/openvpn/tun.c
+++ b/src/openvpn/tun.c
@@ -3305,7 +3305,7 @@ 
                 tt->reads.iostate = IOSTATE_IMMEDIATE_RETURN;
                 tt->reads.status = err;
                 dmsg(D_WIN32_IO, "WIN32 I/O: TAP Read error [%d] : %s", len,
-                     strerror_win32(status, &gc));
+                     strerror_win32(err, &gc));
                 gc_free(&gc);
             }
         }