diff mbox series

[Openvpn-devel,v2] reflect_filter: initialise warning_displayed in the rate limiter

Message ID 20261109091139.4816-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v2] reflect_filter: initialise warning_displayed in the rate limiter |

Commit Message

Gert Doering Nov. 9, 2026, 9:11 a.m. UTC 
  From: Lev Stipakov <lev@openvpn.net>

initial_rate_limit_init() allocates with ALLOC_OBJ, which does not
clear, and assigns every field but warning_displayed. The first period
reset assigns it before anything reads it, so nothing misbehaves today,
but there is no reason to leave a field undefined.

Change-Id: Ied9e36d45b30a88610cafee668ecefa98b29eddc
Signed-off-by: Lev Stipakov <lev@openvpn.net>
Acked-by: Razvan Cojocaru <razvanc@mailbox.org>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2146
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2146
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Razvan Cojocaru <razvanc@mailbox.org>
diff mbox series

Patch

diff --git a/src/openvpn/reflect_filter.c b/src/openvpn/reflect_filter.c
index e5226e4..953fff5 100644
--- a/src/openvpn/reflect_filter.c
+++ b/src/openvpn/reflect_filter.c
@@ -95,6 +95,7 @@ 
     irl->period_length = period_length;
     irl->curr_period_counter = 0;
     irl->last_period_reset = 0;
+    irl->warning_displayed = false;
 
     return irl;
 }