[Openvpn-devel,v2] mudp: drop unused addr parameter of do_pre_decrypt_check()

Message ID 20261117123402.12520-1-gert@greenie.muc.de
State New
Headers
Series [Openvpn-devel,v2] mudp: drop unused addr parameter of do_pre_decrypt_check() |

Commit Message

Gert Doering Nov. 17, 2026, 12:33 p.m. UTC
  From: Razvan Cojocaru <razvanc@mailbox.org>

It was passed by value on every connection attempt and never read.

Change-Id: I388a52d19633d0604a1610fbfba31cfff7f518ef
Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Arne Schwabe <arne-openvpn@rfc2549.org>
Frank Lichtenheld <frank@lichtenheld.com>
  

Comments

Gert Doering Nov. 17, 2026, 5:50 p.m. UTC | #1
Leftover from the old days where incoming sessions where looked-up by
(ip,port) in m->hash.  Out it goes.  Stared-at-code, asked Arne, and
BB all green :-)

2.7 actually uses this parameter (old lookup) so this can't go there.

Your patch has been applied to the master branch.

commit 18483720191ddd0420de73ca7454296977a28808
Author: Razvan Cojocaru
Date:   Tue Nov 17 13:33:57 2026 +0100

     mudp: drop unused addr parameter of do_pre_decrypt_check()

     Signed-off-by: Razvan Cojocaru <razvanc@mailbox.org>
     Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
     Acked-by: Frank Lichtenheld <frank@lichtenheld.com>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/2202
     Message-Id: <20261117123402.12520-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg41526.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
  

Patch

diff --git a/src/openvpn/mudp.c b/src/openvpn/mudp.c
index 217b299..0e1e21d 100644
--- a/src/openvpn/mudp.c
+++ b/src/openvpn/mudp.c
@@ -113,7 +113,7 @@ 
 /** Returns a verdict if this packet should create a new session */
 static enum pre_decrypt_verdict
 do_pre_decrypt_check(struct multi_context *m, struct tls_pre_decrypt_state *state,
-                     struct mroute_addr addr, struct link_socket *sock)
+                     struct link_socket *sock)
 {
     ASSERT(m->top.c2.tls_auth_standalone);
 
@@ -259,7 +259,7 @@ 
     struct tls_pre_decrypt_state state = { 0 };
     struct multi_instance *mi = NULL;
 
-    enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, *real, sock);
+    enum pre_decrypt_verdict verdict = do_pre_decrypt_check(m, &state, sock);
 
     if (verdict != PRE_DECRYPT_NO_ACTION)
     {