[Openvpn-devel,XS] Change in openvpn[master]: check_compression_settings_valid: Do not test for LZ4 in LZO check

Message ID 745034d45020b812fa63dcda984dd56b1e7a36c4-HTML@gerrit.openvpn.net
State Superseded
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: check_compression_settings_valid: Do not test for LZ4 in LZO check | expand

Commit Message

reynir (Code Review) Feb. 16, 2024, 10:09 a.m. UTC
Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/526?usp=email

to review the following change.


Change subject: check_compression_settings_valid: Do not test for LZ4 in LZO check
......................................................................

check_compression_settings_valid: Do not test for LZ4 in LZO check

Probably introduced by copy & paste since there is no
COMP_ALGV2_LZO.

Github: #500
Change-Id: Id6b038c1c0095b2f22033e9dc7090e2507a373ab
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
---
M src/openvpn/comp.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/26/526/1

Patch

diff --git a/src/openvpn/comp.c b/src/openvpn/comp.c
index 6e30369..311f3e9 100644
--- a/src/openvpn/comp.c
+++ b/src/openvpn/comp.c
@@ -195,7 +195,7 @@ 
     }
 #endif
 #ifndef ENABLE_LZO
-    if (info->alg == COMP_ALG_LZO || info->alg == COMP_ALG_LZ4)
+    if (info->alg == COMP_ALG_LZO)
     {
         msg(msglevel, "OpenVPN is compiled without LZO support. Requested "
             "compression cannot be enabled.");