[Openvpn-devel,XS] Change in openvpn[master]: cmake: build native binaries with debug info

Message ID d3be0bd04b5c6f9f96b139cb50f07b0f38176cab-HTML@gerrit.openvpn.net
State Rejected
Headers show
Series [Openvpn-devel,XS] Change in openvpn[master]: cmake: build native binaries with debug info | expand

Commit Message

flichtenheld (Code Review) Dec. 16, 2023, 10:17 a.m. UTC
Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/484?usp=email

to review the following change.


Change subject: cmake: build native binaries with debug info
......................................................................

cmake: build native binaries with debug info

Since the cmake unix builds are not the officially supported way to
build openvpn, it makes sense to always do debug builds for during
development.

Change-Id: I5d835f37d9b75a2eba39504e673597cf7b6f8989
Signed-off-by: Heiko Hund <heiko@ist.eigentlich.net>
---
M CMakePresets.json
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/484/1

Patch

diff --git a/CMakePresets.json b/CMakePresets.json
index 135b19d..46aeeef 100644
--- a/CMakePresets.json
+++ b/CMakePresets.json
@@ -199,8 +199,9 @@ 
             "configuration": "Debug"
         },
         {
-            "name": "unix-native",
-            "configurePreset": "unix-native"
+            "name": "unix-native-debug",
+            "configurePreset": "unix-native",
+            "configuration": "Debug"
         }
     ],
     "testPresets": [