diff mbox series

[Openvpn-devel,v3] tapctl: Remove unused function dont_mute

Message ID 20260419133947.21215-1-gert@greenie.muc.de
State New
Headers show
Series [Openvpn-devel,v3] tapctl: Remove unused function dont_mute | expand

Commit Message

Gert Doering April 19, 2026, 1:39 p.m. UTC 
From: Frank Lichtenheld <frank@lichtenheld.com>

Identified by cppcheck.

Change-Id: I87c40dc94035345add1162e5029e51288811cb09
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
---

This change was reviewed on Gerrit and approved by at least one
developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
This mail reflects revision 3 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <gert@greenie.muc.de>

Comments

Gert Doering April 19, 2026, 3:51 p.m. UTC | #1 
This was a bit nonintuitive at first ("but it does get used... oh, wait,
it's a stub that always returns 'true'").  Well, I guess when Simon
imported the msg_test() function from openvpn/error.h wanted to leave 
those bits unchanged, for easier future adjustments... (which never
happened).

Anyway, out it goes.  Spring cleaning time.  Compile tested with MinGW.

Your patch has been applied to the master branch.

commit 6d54d7ca5d32ebd830298b303a1146365fb35bbc
Author: Frank Lichtenheld
Date:   Sun Apr 19 15:39:41 2026 +0200

     tapctl: Remove unused function dont_mute

     Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
     Acked-by: Gert Doering <gert@greenie.muc.de>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1615
     Message-Id: <20260419133947.21215-1-gert@greenie.muc.de>
     URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36662.html
     Signed-off-by: Gert Doering <gert@greenie.muc.de>


--
kind regards,

Gert Doering
diff mbox series

Patch

diff --git a/src/tapctl/error.h b/src/tapctl/error.h
index 9632b2f..f9586dc 100644
--- a/src/tapctl/error.h
+++ b/src/tapctl/error.h
@@ -109,11 +109,11 @@ 
     return (level & M_DEBUG_LEVEL) <= x_debug_level;
 }
 
-/** Return true if flags represent and enabled, not muted log level */
+/** Return true if flags represent */
 static inline bool
 msg_test(unsigned int flags)
 {
-    return check_debug_level(flags) && dont_mute(flags);
+    return check_debug_level(flags);
 }
 
 #endif /* ifndef ERROR_H */
diff --git a/src/tapctl/main.c b/src/tapctl/main.c
index 1d047dd..6a4a240 100644
--- a/src/tapctl/main.c
+++ b/src/tapctl/main.c
@@ -686,15 +686,6 @@ 
 }
 
 
-bool
-dont_mute(unsigned int flags)
-{
-    UNREFERENCED_PARAMETER(flags);
-
-    return true;
-}
-
-
 void
 x_msg_va(const unsigned int flags, const char *format, va_list arglist)
 {